From: Peter Zijlstra <peterz@infradead.org>
To: Ingo Molnar <mingo@elte.hu>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Arjan van de Ven <arjan@infradead.org>,
Paul Mackerras <paulus@samba.org>,
Thomas Gleixner <tglx@linutronix.de>,
Andrew Morton <akpm@linux-foundation.org>,
Linus Torvalds <torvalds@linux-foundation.org>,
Christoph Hellwig <hch@infradead.org>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] perf: remove PERF_SAMPLE_RAW
Date: Thu, 27 Aug 2009 11:04:33 +0200 [thread overview]
Message-ID: <1251363873.18584.49.camel@twins> (raw)
In-Reply-To: <20090827084321.GD2131@elte.hu>
On Thu, 2009-08-27 at 10:43 +0200, Ingo Molnar wrote:
> * Peter Zijlstra <peterz@infradead.org> wrote:
>
> > Apparently people think trace-events became an ABI the moment perf
> > exported them, regardless what the text surrounding
> > PERF_SAMPLE_RAW said about the opaqueness of the data provided.
>
> Well it's still opaque and the descriptor of what it means is in
> debugfs so it's not an ABI as the comment says.
Clearly people their expectations didn't match this.
> > I'm not willing to make anything trace related into an ABI, hence
> > remove this.
>
> This removes quite a bit of nice functionality we already have, so i
> think it's (way) too heavy handed.
>
> I think what we want is the golden middle: a per tracepoint
> property. I.e. we would provide:
>
> TRACE_EVENT_STABLE()
>
> or TRACE_EVENT_CORE() or TRACE_EVENT_ABI() - which carries a 'will
> maintain this as an ABI' promise from the maintainer who adds it.
>
> Also, tracepoints are a unidirectional channel of information - in
> practice those are way easier to handle as an ABI than other ABIs
> such as behavior, semantics, etc. So i'd expect there to be a
> healthy set of 'stable' tracepoints.
Whatever works for people really, I just want this discussed. I'm not at
all ready to have everything TRACE_EVENT() declared an ABI as it stands
now.
next prev parent reply other threads:[~2009-08-27 9:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-08-27 8:17 [PATCH] perf: remove PERF_SAMPLE_RAW Peter Zijlstra
2009-08-27 8:43 ` Ingo Molnar
2009-08-27 9:04 ` Peter Zijlstra [this message]
2009-08-27 13:35 ` Frederic Weisbecker
2009-08-27 13:26 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251363873.18584.49.camel@twins \
--to=peterz@infradead.org \
--cc=akpm@linux-foundation.org \
--cc=arjan@infradead.org \
--cc=fweisbec@gmail.com \
--cc=hch@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox