From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: ego@in.ibm.com
Cc: Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org,
Andreas Herrmann <andreas.herrmann3@amd.com>,
Balbir Singh <balbir@in.ibm.com>
Subject: Re: [RFC][PATCH 3/8] sched: update the cpu_power sum during load-balance
Date: Wed, 02 Sep 2009 13:25:06 +0200 [thread overview]
Message-ID: <1251890706.7547.150.camel@twins> (raw)
In-Reply-To: <20090902111759.GB3817@in.ibm.com>
On Wed, 2009-09-02 at 16:47 +0530, Gautham R Shenoy wrote:
> > + if (local_group) {
> > balance_cpu = group_first_cpu(group);
> > + if (balance_cpu == this_cpu)
> > + update_sched_power(sd);
> > + }
>
> I guess the intention of this check is to ensure that the cpu_power for
> the group of sd is updated only by a specific member of the group and
> that would ideally be the first member of the group.
>
> Thus, this check has more to do with this_cpu being the
> group_first_cpu() than this_cpu being the balance_cpu. Correct ?
Right, so the load-balancer walks the sd tree in the fashion that only
the first cpu of the domain goes up a level. So I made that cpu also
aggregate the new cpu-power.
next prev parent reply other threads:[~2009-09-02 11:25 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-01 8:34 [RFC][PATCH 0/8] load-balancing and cpu_power -v2 Peter Zijlstra
2009-09-01 8:34 ` [RFC][PATCH 1/8] sched: restore __cpu_power to a straight sum of power Peter Zijlstra
2009-09-04 8:54 ` [tip:sched/balancing] sched: Restore " tip-bot for Peter Zijlstra
2009-09-01 8:34 ` [RFC][PATCH 2/8] sched: SD_PREFER_SIBLING Peter Zijlstra
2009-09-04 8:55 ` [tip:sched/balancing] sched: Add SD_PREFER_SIBLING tip-bot for Peter Zijlstra
2009-09-01 8:34 ` [RFC][PATCH 3/8] sched: update the cpu_power sum during load-balance Peter Zijlstra
2009-09-02 11:17 ` Gautham R Shenoy
2009-09-02 11:25 ` Peter Zijlstra [this message]
2009-09-04 8:55 ` [tip:sched/balancing] sched: Update " tip-bot for Peter Zijlstra
2009-09-01 8:34 ` [RFC][PATCH 4/8] sched: add smt_gain Peter Zijlstra
2009-09-02 11:22 ` Gautham R Shenoy
2009-09-02 11:26 ` Peter Zijlstra
2009-09-04 8:55 ` [tip:sched/balancing] sched: Add smt_gain tip-bot for Peter Zijlstra
2009-09-01 8:34 ` [RFC][PATCH 5/8] sched: dynamic cpu_power Peter Zijlstra
2009-09-02 11:24 ` Gautham R Shenoy
2009-09-04 8:55 ` [tip:sched/balancing] sched: Implement " tip-bot for Peter Zijlstra
2009-09-01 8:34 ` [RFC][PATCH 6/8] sched: scale down cpu_power due to RT tasks Peter Zijlstra
2009-09-04 8:56 ` [tip:sched/balancing] sched: Scale " tip-bot for Peter Zijlstra
2009-09-01 8:34 ` [RFC][PATCH 7/8] sched: try to deal with low capacity Peter Zijlstra
2009-09-02 11:29 ` Gautham R Shenoy
2009-09-04 8:56 ` [tip:sched/balancing] sched: Try " tip-bot for Peter Zijlstra
2009-09-01 8:34 ` [RFC][PATCH 8/8] sched: remove reciprocal for cpu_power Peter Zijlstra
2009-09-03 12:12 ` Andreas Herrmann
2009-09-04 8:56 ` [tip:sched/balancing] sched: Remove " tip-bot for Peter Zijlstra
2009-09-02 10:57 ` [RFC][PATCH 0/8] load-balancing and cpu_power -v2 Gautham R Shenoy
2009-09-03 12:10 ` Andreas Herrmann
2009-09-03 13:38 ` Peter Zijlstra
2009-09-04 7:19 ` Ingo Molnar
2009-09-04 9:27 ` [crash] " Ingo Molnar
2009-09-04 10:25 ` [tip:sched/balancing] sched: Fix dynamic power-balancing crash tip-bot for Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1251890706.7547.150.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=andreas.herrmann3@amd.com \
--cc=balbir@in.ibm.com \
--cc=ego@in.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox