public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH] builddeb: Fix packaged file permissions
@ 2009-09-03 22:00 Ben Hutchings
  2009-09-04 18:55 ` Frans Pop
  0 siblings, 1 reply; 2+ messages in thread
From: Ben Hutchings @ 2009-09-03 22:00 UTC (permalink / raw)
  To: linux-kernel; +Cc: maximilian attems, Frans Pop

The packaged files' permissions are implicitly dependent on the
current umask.  Not only can this result in surprisingly restrictive
permissions, but dpkg-deb will fail if the DEBIAN directory does not
have permissions 755 or 775.  Therefore, set the umask to 022 before
building a package.

Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
---
 scripts/package/builddeb |    2 ++
 1 files changed, 2 insertions(+), 0 deletions(-)

diff --git a/scripts/package/builddeb b/scripts/package/builddeb
index 8b357b0..24cfd80 100644
--- a/scripts/package/builddeb
+++ b/scripts/package/builddeb
@@ -12,6 +12,8 @@
 
 set -e
 
+umask 022
+
 create_package() {
 	local pname="$1" pdir="$2"
 
-- 
1.6.3.3


^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] builddeb: Fix packaged file permissions
  2009-09-03 22:00 [PATCH] builddeb: Fix packaged file permissions Ben Hutchings
@ 2009-09-04 18:55 ` Frans Pop
  0 siblings, 0 replies; 2+ messages in thread
From: Frans Pop @ 2009-09-04 18:55 UTC (permalink / raw)
  To: Ben Hutchings; +Cc: linux-kernel, maximilian attems, linux-kbuild

Added linux-kbuild to CC.

On Friday 04 September 2009, Ben Hutchings wrote:
> The packaged files' permissions are implicitly dependent on the
> current umask.  Not only can this result in surprisingly restrictive
> permissions, but dpkg-deb will fail if the DEBIAN directory does not
> have permissions 755 or 775.  Therefore, set the umask to 022 before
> building a package.
>
> Signed-off-by: Ben Hutchings <ben@decadent.org.uk>
Acked-by: Frans Pop <elendil@planet.nl>

> ---
>  scripts/package/builddeb |    2 ++
>  1 files changed, 2 insertions(+), 0 deletions(-)
>
> diff --git a/scripts/package/builddeb b/scripts/package/builddeb
> index 8b357b0..24cfd80 100644
> --- a/scripts/package/builddeb
> +++ b/scripts/package/builddeb
> @@ -12,6 +12,8 @@
>
>  set -e
>
> +umask 022
> +
>  create_package() {
>  	local pname="$1" pdir="$2"
> 

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-09-04 18:55 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-09-03 22:00 [PATCH] builddeb: Fix packaged file permissions Ben Hutchings
2009-09-04 18:55 ` Frans Pop

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox