From: Daniel Walker <dwalker@fifo99.com>
To: Stefan Assmann <sassmann@redhat.com>
Cc: linux-kernel@vger.kernel.org, jcm@redhat.com,
sdietrich@novell.com, linux-acpi@vger.kernel.org,
andi@firstfloor.org, hpa@zytor.com, mingo@elte.hu,
Olaf.Dabrunz@gmx.net, ktokunag@redhat.com, tglx@linutronix.de,
lenb@kernel.org
Subject: Re: [RFC][PATCH 2/2] disable boot interrupts on Intel X58 and 55x0
Date: Fri, 04 Sep 2009 10:06:59 -0700 [thread overview]
Message-ID: <1252084019.22928.39.camel@desktop> (raw)
In-Reply-To: <20090904165545.26294.94612.sendpatchset@t500>
On Fri, 2009-09-04 at 12:55 -0400, Stefan Assmann wrote:
> + * Disable boot interrupts on Intel X58, 55x0 (Tylersburg).
> + * See Intel document #321328-001, section 19.10.2.27.
> + * (Disable PCI INTx Routing to ICH)
> + */
> +#define INTEL_X58_55x0_QPIPINTRC_OFFSET 0xe0
> +#define INTEL_X58_55x0_QPIPINTRC_BIT (1<<25)
> +static void quirk_disable_intel_tylersburg_boot_interrupt(struct
> pci_dev *dev)
> +{
> + u32 pci_config_dword;
> +
> + if (noioapicquirk)
> + return;
> +
> + pci_read_config_dword(dev, INTEL_X58_55x0_QPIPINTRC_OFFSET,
> &pci_config_dword);
> + pci_config_dword |= INTEL_X58_55x0_QPIPINTRC_BIT;
> + pci_write_config_dword(dev, INTEL_X58_55x0_QPIPINTRC_OFFSET,
> pci_config_dword);
> +
> + printk(KERN_INFO "disabled boot interrupt on device 0x%04x:0x%
> 04x\n",
> + dev->vendor, dev->device);
> +}
> +DECLARE_PCI_FIXUP_FINAL(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QPI_TBG15, quirk_disable_intel_tylersburg_boot_interrupt);
> +DECLARE_PCI_FIXUP_RESUME(PCI_VENDOR_ID_INTEL, PCI_DEVICE_ID_INTEL_QPI_TBG15, quirk_disable_intel_tylersburg_boot_interrupt);
These lines are wildly long .. Could you reduce these down to a max of
80 characters..
Daniel
next prev parent reply other threads:[~2009-09-04 17:06 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-04 16:55 [RFC][PATCH 0/2] boot interrupts on Intel X58 and 55x0 Stefan Assmann
2009-09-04 16:55 ` [RFC][PATCH 1/2] show Intel QuickPath Interconnect Routing and Protocol Layer Registers in PCI config space Stefan Assmann
2009-09-04 17:07 ` Yinghai Lu
2009-09-05 9:02 ` Stefan Assmann
2009-09-04 16:55 ` [RFC][PATCH 2/2] disable boot interrupts on Intel X58 and 55x0 Stefan Assmann
2009-09-04 17:06 ` Daniel Walker [this message]
2009-09-05 9:07 ` Stefan Assmann
2009-09-05 14:47 ` Daniel Walker
2009-09-05 16:18 ` Olaf Dabrunz
2009-09-05 17:07 ` Daniel Walker
2009-09-07 1:37 ` Henrique de Moraes Holschuh
2009-09-07 1:53 ` Daniel Walker
2009-09-07 1:33 ` [RFC][PATCH 0/2] " Henrique de Moraes Holschuh
2009-09-07 8:24 ` Stefan Assmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252084019.22928.39.camel@desktop \
--to=dwalker@fifo99.com \
--cc=Olaf.Dabrunz@gmx.net \
--cc=andi@firstfloor.org \
--cc=hpa@zytor.com \
--cc=jcm@redhat.com \
--cc=ktokunag@redhat.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sassmann@redhat.com \
--cc=sdietrich@novell.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).