Re: mmotm 2011-01-06-15-41 uploaded (apple_bl)

Randy Dunlap
2011-01-07T17:18:56Z

On Thu, 06 Jan 2011 15:41:14 -0800 akpm@linux-foundation.org wrote:

> The mm-of-the-moment snapshot 2011-01-06-15-41 has been uploaded to
>
> http://userweb.kernel.org/~akpm/mmotm/
>
> and will soon be available at
>
> git://zen-kernel.org/kernel/mmotm.git
>
> It contains the following patches against 2.6.37:

When ACPI is not enabled:

drivers/video/backlight/apple_bl.c:142: warning: 'struct acpi_device' declared inside parameter list
drivers/video/backlight/apple_bl.c:142: warning: its scope is only this definition or declaration, which is probably not what you want
drivers/video/backlight/apple_bl.c:200: warning: 'struct acpi_device' declared inside parameter list
drivers/video/backlight/apple_bl.c:214: error: variable 'apple_bl_driver' has initializer but incomplete type
drivers/video/backlight/apple_bl.c:215: error: unknown field 'name' specified in initializer
drivers/video/backlight/apple_bl.c:215: warning: excess elements in struct initializer
drivers/video/backlight/apple_bl.c:215: warning: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:216: error: unknown field 'ids' specified in initializer
drivers/video/backlight/apple_bl.c:216: warning: excess elements in struct initializer
drivers/video/backlight/apple_bl.c:216: warning: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:217: error: unknown field 'ops' specified in initializer
drivers/video/backlight/apple_bl.c:217: error: extra brace group at end of initializer
drivers/video/backlight/apple_bl.c:217: error: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c:220: warning: excess elements in struct initializer
drivers/video/backlight/apple_bl.c:220: warning: (near initialization for 'apple_bl_driver')
drivers/video/backlight/apple_bl.c: In function 'apple_bl_init':
drivers/video/backlight/apple_bl.c:225: error: implicit declaration of function 'acpi_bus_register_driver'
drivers/video/backlight/apple_bl.c: In function 'apple_bl_exit':
drivers/video/backlight/apple_bl.c:230: error: implicit declaration of function 'acpi_bus_unregister_driver'

Should BACKLIGHT_APPLE also depend on ACPI?

---
~Randy
*** Remember to use Documentation/SubmitChecklist when testing your code ***