public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <rpurdie@rpsys.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: lenz@cs.wisc.edu, kernel list <linux-kernel@vger.kernel.org>,
	Dirk@Opfer-Online.de, arminlitzel@web.de,
	Cyril Hrubis <metan@ucw.cz>,
	thommycheck@gmail.com,
	linux-arm-kernel <linux-arm-kernel@lists.arm.linux.org.uk>,
	dbaryshkov@gmail.com, omegamoon@gmail.com, eric.miao@marvell.com,
	utx@penguin.cz
Subject: Re: Zaurus suspend saga
Date: Sun, 06 Sep 2009 23:29:05 +0100	[thread overview]
Message-ID: <1252276145.17852.15.camel@dax.rpnet.com> (raw)
In-Reply-To: <20090906052653.GB1324@ucw.cz>

On Sun, 2009-09-06 at 07:26 +0200, Pavel Machek wrote:
> fatal reads invalid values -- -108 -- probably because spi is not ready?
> 
> is spi suspend/resume required? yes.; and yes spi is resumed too late
>  in the sequence. Or perhaps fatal battery check is way too early.
> 
> Could someone confirm that simply removing sharpsl_fatal_check() fixes
> zaurus suspend on 2.6.31? 

Sadly lack of time means I've lost track of the Zaurus kernels but this
sounds like all accesses to the SSP buses now go through the SPI layer
and when it was converted nobody thought about the impact this would
have on the Zaurus charger code.

If suspend/resume is broken in this way, it also means the charger code
is also likely to be totally broken/malfunctioning since it won't be
able to read from the ADC either.

Either:

a) Someone steps up and finds a way to partially resume the kernel so
the "offline" charging code can work and access SPI
b) We find some other way to allow the SPI interface to be accessed by
the charger code without resuming the whole kernel (the way it used to
work)
c) We rip the whole thing out and stop supporting "offline" charging.

I'd hate to see c) happen but I doubt I'm going to find time to rewrite
that code any time soon and nobody else even seems to have grasped how
deep this problem really is :(.

Richard


  parent reply	other threads:[~2009-09-06 22:29 UTC|newest]

Thread overview: 22+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-06  5:26 Zaurus suspend saga Pavel Machek
2009-09-06 17:03 ` Rafael J. Wysocki
2009-09-06 18:01   ` Stanislav Brabec
2009-09-07 10:04   ` Pavel Machek
2009-09-06 22:29 ` Richard Purdie [this message]
2009-09-07  1:06   ` Eric Miao
2009-09-07 11:03     ` Pavel Machek
2009-09-07 11:34       ` Stanislav Brabec
2009-09-07 11:48         ` Russell King - ARM Linux
2009-09-16 12:25           ` Stanislav Brabec
2009-10-02  4:13         ` Pavel Machek
2009-10-02  7:36           ` Joe Perches
2009-09-07 12:05       ` Dmitry Eremin-Solenikov
2009-09-07 11:31   ` Pavel Machek
2009-09-07 13:10     ` Stanislav Brabec
2009-09-07 14:07       ` Richard Purdie
2009-09-07 14:52         ` Eric Miao
2009-09-07 20:36         ` Dmitry Eremin-Solenikov
2009-09-07 14:46       ` Eric Miao
2009-09-08 21:19       ` Pavel Machek
2009-09-08 21:53       ` Pavel Machek
2009-09-09  9:28         ` Stanislav Brabec

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252276145.17852.15.camel@dax.rpnet.com \
    --to=rpurdie@rpsys.net \
    --cc=Dirk@Opfer-Online.de \
    --cc=arminlitzel@web.de \
    --cc=dbaryshkov@gmail.com \
    --cc=eric.miao@marvell.com \
    --cc=lenz@cs.wisc.edu \
    --cc=linux-arm-kernel@lists.arm.linux.org.uk \
    --cc=linux-kernel@vger.kernel.org \
    --cc=metan@ucw.cz \
    --cc=omegamoon@gmail.com \
    --cc=pavel@ucw.cz \
    --cc=thommycheck@gmail.com \
    --cc=utx@penguin.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox