From: Daniel Walker <dwalker@fifo99.com>
To: Tilman Schmidt <tilman@imap.cc>
Cc: davem@davemloft.net, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, i4ldeveloper@listserv.isdn4linux.de,
Hansjoerg Lipp <hjlipp@web.de>
Subject: Re: [PATCH 00/12] Gigaset driver patches for 2.6.32
Date: Mon, 07 Sep 2009 07:30:55 -0700 [thread overview]
Message-ID: <1252333855.2139.15.camel@desktop> (raw)
In-Reply-To: <4AA4CD64.4070501@imap.cc>
On Mon, 2009-09-07 at 11:07 +0200, Tilman Schmidt wrote:
> Daniel,
>
> thanks for taking a look at my patches.
>
> On Sun, 06 Sep 2009 18:26:46 -0700, Daniel Walker wrote:
> > patches 6,7,10, and 12 all have checkpatch errors. Could you fix those?
>
> I have reissued patch 7, exchanging the "static" and "inline" keywords
> as requested.
>
> The other patches I'd much prefer to keep as they are. The "ERRORs"
> checkpatch.pl reported for them are results of keeping to the existing
> formatting of the patched files. Completely reformatting them would
> cloud the actual changes made by the patches.
Yeah, it looks like the whole file needs a checkpatch clean up.. Sounds
like your not willing to do that? Usually if a checkpatch cleanup comes
first prior to all your other changes , it doesn't usually cloud the
rest of the changes..
Daniel
next prev parent reply other threads:[~2009-09-07 14:30 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-06 18:58 [PATCH 00/12] Gigaset driver patches for 2.6.32 Tilman Schmidt
2009-09-06 18:58 ` [PATCH 06/12] gigaset: fix device ERROR response handling Tilman Schmidt
2009-09-06 18:58 ` [PATCH 08/12] gigaset: correct debugging output selection Tilman Schmidt
2009-09-06 18:58 ` [PATCH 07/12] gigaset: improve error recovery Tilman Schmidt
2009-09-07 8:59 ` [PATCH 07/12 v2] " Tilman Schmidt
2009-09-06 18:58 ` [PATCH 01/12] gigaset: really fix chars_in_buffer Tilman Schmidt
2009-09-06 18:58 ` [PATCH 04/12] gigaset: handle isoc frame errors more gracefully Tilman Schmidt
2009-09-06 18:58 ` [PATCH 09/12] gigaset: add kerneldoc comments Tilman Schmidt
2009-09-06 18:58 ` [PATCH 11/12] gigaset: allow building without I4L Tilman Schmidt
2009-09-06 18:58 ` [PATCH 10/12] gigaset: prepare for CAPI implementation Tilman Schmidt
2009-09-06 18:58 ` [PATCH 05/12] gigaset: announce if built with debugging Tilman Schmidt
2009-09-06 18:58 ` [PATCH 02/12] gigaset: fix reject/hangup handling Tilman Schmidt
2009-09-06 18:58 ` [PATCH 12/12] gigaset: add Kernel CAPI interface Tilman Schmidt
2009-09-06 18:58 ` [PATCH 03/12] gigaset: linearize skb Tilman Schmidt
2009-09-07 1:26 ` [PATCH 00/12] Gigaset driver patches for 2.6.32 Daniel Walker
2009-09-07 9:07 ` Tilman Schmidt
2009-09-07 14:30 ` Daniel Walker [this message]
2009-09-07 9:00 ` David Miller
2009-09-07 9:11 ` Tilman Schmidt
2009-09-07 9:18 ` David Miller
2009-09-07 18:56 ` Karsten Keil
[not found] <20090909223205.E9D632269516@fifo99.com>
2009-09-10 3:47 ` Daniel Walker
2009-09-10 3:51 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252333855.2139.15.camel@desktop \
--to=dwalker@fifo99.com \
--cc=davem@davemloft.net \
--cc=hjlipp@web.de \
--cc=i4ldeveloper@listserv.isdn4linux.de \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=tilman@imap.cc \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox