From: Sheng Yang <sheng@linux.intel.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: linux-kernel@vger.kernel.org, Sheng Yang <sheng@linux.intel.com>,
Dimitri Sivanich <sivanich@sgi.com>
Subject: [PATCH] x86: Don't ack_APIC_irq() if lapic is disabled in GENERIC_INTERRUPT_VECTOR handler
Date: Tue, 8 Sep 2009 17:52:26 +0800 [thread overview]
Message-ID: <1252403546-12544-1-git-send-email-sheng@linux.intel.com> (raw)
Otherwise would cause trouble...
Cc: Dimitri Sivanich <sivanich@sgi.com>
Signed-off-by: Sheng Yang <sheng@linux.intel.com>
---
arch/x86/kernel/irq.c | 3 ++-
1 files changed, 2 insertions(+), 1 deletions(-)
diff --git a/arch/x86/kernel/irq.c b/arch/x86/kernel/irq.c
index b0cdde6..78b23d0 100644
--- a/arch/x86/kernel/irq.c
+++ b/arch/x86/kernel/irq.c
@@ -257,7 +257,8 @@ void smp_generic_interrupt(struct pt_regs *regs)
{
struct pt_regs *old_regs = set_irq_regs(regs);
- ack_APIC_irq();
+ if (!disable_apic)
+ ack_APIC_irq();
exit_idle();
--
1.5.4.5
next reply other threads:[~2009-09-08 9:56 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-08 9:52 Sheng Yang [this message]
2009-09-20 18:06 ` [PATCH] x86: Don't ack_APIC_irq() if lapic is disabled in GENERIC_INTERRUPT_VECTOR handler Ingo Molnar
2009-09-20 18:13 ` Cyrill Gorcunov
2009-09-20 18:21 ` Ingo Molnar
2009-09-20 18:30 ` Cyrill Gorcunov
2009-09-20 18:42 ` Cyrill Gorcunov
2009-09-20 18:49 ` Cyrill Gorcunov
2009-09-20 19:07 ` Sheng Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252403546-12544-1-git-send-email-sheng@linux.intel.com \
--to=sheng@linux.intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=sivanich@sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox