From: Daniel Walker <dwalker@fifo99.com>
To: Joe Perches <joe@perches.com>
Cc: Tim Abbott <tabbott@ksplice.com>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Sam Ravnborg <sam@ravnborg.org>
Subject: Re: [PATCH v2 2/5] Use new __init_task_data macro in arch init_task.c files.
Date: Tue, 08 Sep 2009 20:21:22 -0700 [thread overview]
Message-ID: <1252466482.14793.60.camel@desktop> (raw)
In-Reply-To: <1252465802.28130.9.camel@Joe-Laptop.home>
On Tue, 2009-09-08 at 20:10 -0700, Joe Perches wrote:
> On Tue, 2009-09-08 at 20:07 -0700, Daniel Walker wrote:
> > On Tue, 2009-09-08 at 20:03 -0700, Joe Perches wrote:
> > > On Tue, 2009-09-08 at 19:58 -0700, Daniel Walker wrote:
> > > > On Tue, 2009-09-08 at 22:49 -0400, Tim Abbott wrote:
> > > > > +union thread_union init_thread_union __init_task_data =
> > > > > + { INIT_THREAD_INFO(init_task) };
> > > > All the lines like the above are all producing checkpatch errors.. It
> > > > looks like the open brace needs to be up with the equals ..
> > > Some checkpatch errors are ignorable.
> > > checkpatch output is a guide, not a rule.
> >
> > Not errors, those aren't usually ignorable .. Warnings, those could be..
>
> Shrug. So submit a patch...
I would if this was code in the kernel already, but it's not. LKML
submission is the process people use to find these types of issues.
Issues that should be fixed prior to inclusion, and may have been
overlooked..
Daniel
next prev parent reply other threads:[~2009-09-09 3:21 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-09 2:49 [PATCH v2 0/5] Use macros rather than hardcoding section names Tim Abbott
2009-09-09 2:49 ` [PATCH v2 1/5] kbuild: Don't define ALIGN and ENTRY when preprocessing linker scripts Tim Abbott
2009-09-09 2:49 ` [PATCH v2 2/5] Use new __init_task_data macro in arch init_task.c files Tim Abbott
2009-09-09 2:55 ` Paul Mundt
2009-09-09 2:58 ` Daniel Walker
2009-09-09 3:03 ` Joe Perches
2009-09-09 3:07 ` Daniel Walker
2009-09-09 3:10 ` Joe Perches
2009-09-09 3:21 ` Daniel Walker [this message]
2009-09-09 3:31 ` Joe Perches
2009-09-09 3:44 ` Daniel Walker
2009-09-09 3:49 ` Joe Perches
2009-09-09 3:32 ` Paul Mundt
2009-09-09 4:11 ` Dmitry Torokhov
2009-09-09 2:49 ` [PATCH v2 3/5] Use macros for .bss.page_aligned section Tim Abbott
2009-09-09 2:54 ` Paul Mundt
2009-09-09 2:49 ` [PATCH v2 4/5] powerpc: remove unused __page_aligned definition Tim Abbott
2009-09-11 7:33 ` Benjamin Herrenschmidt
2009-09-09 2:49 ` [PATCH v2 5/5] Use macros for .data.page_aligned section Tim Abbott
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252466482.14793.60.camel@desktop \
--to=dwalker@fifo99.com \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=sam@ravnborg.org \
--cc=tabbott@ksplice.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox