public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: john stultz <johnstul@us.ibm.com>
To: Yong Zhang <yong.zhang0@gmail.com>
Cc: ye janboe <janboe.ye@gmail.com>,
	zippel@linux-m68k.org, akpm@linux-foundation.org, mingo@elte.hu,
	linux-kernel <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] update clocksource raw_time in timekeeping_suspend
Date: Thu, 10 Sep 2009 15:15:38 -0700	[thread overview]
Message-ID: <1252620938.7319.3.camel@localhost.localdomain> (raw)
In-Reply-To: <2674af740909100231x582851dbv9b71bc2914be7030@mail.gmail.com>

On Thu, 2009-09-10 at 17:31 +0800, Yong Zhang wrote:
> On Thu, Sep 10, 2009 at 4:07 PM, ye janboe <janboe.ye@gmail.com> wrote:
> > hi, John
> >
> > Thanks for your comments.
> >
> > After sent this patch, I realize that this patch exposes the hardware
> > detail ugly in common code.
> >
> > In embed system, user space apps need to have a method to get the
> > right time which will not be impacted by NTP and suspend.
> >
> > Yes, you are right. I want to add sleep_length to the raw time and
> > user space apps could get the right time after suspend.
> >
> 
> What I get from the code is that CLOCK_MONOTONIC doesn't consider
> sleep_length either. Do I miss something?

You're quite right. I forgot we drop sleep_length from
wall_to_monotonic, so it should not increase while we're suspended.

Janboe: So I think things are fine as they stand. No patch necessary.

But please let me know if I'm yet again forgetting something or you're
finding CLOCK_MONOTONIC_RAW to be insufficient in some way.

thanks
-john


  reply	other threads:[~2009-09-10 22:16 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-09  7:35 [PATCH] update clocksource raw_time in timekeeping_suspend ye janboe
2009-09-09 14:25 ` Yong Zhang
2009-09-09 22:32   ` ye janboe
2009-09-09 23:07 ` john stultz
2009-09-10  8:07   ` ye janboe
2009-09-10  9:31     ` Yong Zhang
2009-09-10 22:15       ` john stultz [this message]
2009-09-11  3:35         ` ye janboe
2009-09-11 18:09           ` john stultz

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1252620938.7319.3.camel@localhost.localdomain \
    --to=johnstul@us.ibm.com \
    --cc=akpm@linux-foundation.org \
    --cc=janboe.ye@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=yong.zhang0@gmail.com \
    --cc=zippel@linux-m68k.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox