From: Daniel Walker <dwalker@fifo99.com>
To: "Nicholas A. Bellinger" <nab@linux-iscsi.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Greg KH <greg@kroah.com>, Douglas Gilbert <dgilbert@interlog.com>,
James Bottomley <James.Bottomley@HansenPartnership.com>,
Hannes Reinecke <hare@suse.de>,
FUJITA Tomonori <fujita.tomonori@lab.ntt.co.jp>,
Mike Christie <michaelc@cs.wisc.edu>,
Joel Becker <joel.becker@oracle.com>,
"Martin K. Petersen" <martin.petersen@oracle.com>,
Christoph Hellwig <hch@lst.de>,
Linus Torvalds <torvalds@linux-foundation.org>,
Alan Stern <stern@rowland.harvard.edu>,
Boaz Harrosh <bharrosh@panasas.com>,
Florian Haas <florian.haas@linbit.com>,
Philipp Reisner <philipp.reisner@linbit.com>
Subject: Re: [RFC PATCH 0/19] A kernel-level configfs enabled generic target engine for Linux v2.6.32
Date: Fri, 11 Sep 2009 19:37:40 -0700 [thread overview]
Message-ID: <1252723060.28368.48.camel@desktop> (raw)
In-Reply-To: <1252720508.2067.196.camel@haakon2.linux-iscsi.org>
On Fri, 2009-09-11 at 18:55 -0700, Nicholas A. Bellinger wrote:
> There is cleanup work continuing to make the TCM code to use
> dprintk(),
> and some include cleanups, and other minor fixes. The code has also
> been run through checkpatch again since the posting in April, and all
> errors have been removed, with the exception of one ConfigFS macro
> define triggering a checkpatch false positive.
One show stopping issue is that your adding new semaphore usage in patch
5 and 16 (and in 16 it's a LOCKED one wtf!!). Which you should not be
doing .. You need to really evaluate the warnings from checkpatch, cause
those still have meaning..
It's basically telling you what you should be doing in the warnings..
For instance, don't add new semaphore usage, and it tells you what you
need to be using in place of them.. Also typedefs are frowned upon, so
you could remove those..
Daniel
next prev parent reply other threads:[~2009-09-12 2:37 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 1:55 [RFC PATCH 0/19] A kernel-level configfs enabled generic target engine for Linux v2.6.32 Nicholas A. Bellinger
2009-09-12 2:37 ` Daniel Walker [this message]
2009-09-12 3:08 ` Nicholas A. Bellinger
2009-09-12 3:17 ` Daniel Walker
2009-09-12 3:24 ` Nicholas A. Bellinger
2009-09-13 10:10 ` Boaz Harrosh
2009-09-14 19:59 ` Nicholas A. Bellinger
2009-09-14 18:50 ` Vladislav Bolkhovitin
2009-09-14 20:49 ` Nicholas A. Bellinger
2009-09-15 18:08 ` Vladislav Bolkhovitin
2009-09-14 20:12 ` Chetan.Loke
2009-09-14 21:06 ` Nicholas A. Bellinger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252723060.28368.48.camel@desktop \
--to=dwalker@fifo99.com \
--cc=James.Bottomley@HansenPartnership.com \
--cc=akpm@linux-foundation.org \
--cc=bharrosh@panasas.com \
--cc=dgilbert@interlog.com \
--cc=florian.haas@linbit.com \
--cc=fujita.tomonori@lab.ntt.co.jp \
--cc=greg@kroah.com \
--cc=hare@suse.de \
--cc=hch@lst.de \
--cc=joel.becker@oracle.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=martin.petersen@oracle.com \
--cc=michaelc@cs.wisc.edu \
--cc=nab@linux-iscsi.org \
--cc=philipp.reisner@linbit.com \
--cc=stern@rowland.harvard.edu \
--cc=torvalds@linux-foundation.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox