From: Daniel Walker <dwalker@fifo99.com>
To: Wu Fengguang <fengguang.wu@intel.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
Andi Kleen <ak@linux.intel.com>, Avi Kivity <avi@qumranet.com>,
Greg Kroah-Hartman <gregkh@suse.de>,
Johannes Berg <johannes@sipsolutions.net>,
Marcelo Tosatti <mtosatti@redhat.com>,
Mark Brown <broonie@opensource.wolfsonmicro.com>,
LKML <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH 3/3] devmem: remove redundant parameter from do_write_kmem()
Date: Sat, 12 Sep 2009 08:30:54 -0700 [thread overview]
Message-ID: <1252769454.28368.66.camel@desktop> (raw)
In-Reply-To: <20090912152259.384529634@intel.com>
On Sat, 2009-09-12 at 23:20 +0800, Wu Fengguang wrote:
> static inline ssize_t
> -do_write_kmem(void *p, unsigned long realp, const char __user * buf,
> +do_write_kmem(unsigned long p, const char __user * buf,
> size_t count, loff_t *ppos)
> {
There's one style issue in the block above. Could you run your patches
through checkpatch and fix whatever errors it reports?
Daniel
next prev parent reply other threads:[~2009-09-12 15:30 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-12 15:20 [PATCH 0/3] more /dev/[k]mem cleanups Wu Fengguang
2009-09-12 15:20 ` [PATCH 1/3] devmem: make size_inside_page() logic straight Wu Fengguang
2009-09-12 15:20 ` [PATCH 2/3] devmem: remove the "written" variable in write_kmem() Wu Fengguang
2009-09-12 15:20 ` [PATCH 3/3] devmem: remove redundant parameter from do_write_kmem() Wu Fengguang
2009-09-12 15:30 ` Daniel Walker [this message]
2009-09-12 15:36 ` Wu Fengguang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252769454.28368.66.camel@desktop \
--to=dwalker@fifo99.com \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=avi@qumranet.com \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=fengguang.wu@intel.com \
--cc=gregkh@suse.de \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=mtosatti@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox