From: Daniel Walker <dwalker@fifo99.com>
To: Felipe Contreras <felipe.contreras@gmail.com>
Cc: linux-kernel@vger.kernel.org, Len Brown <lenb@kernel.org>,
Len Brown <len.brown@intel.com>, Lin Ming <ming.m.lin@intel.com>,
Bob Moore <robert.moore@intel.com>,
Andi Kleen <ak@linux.intel.com>,
linux-acpi@vger.kernel.org
Subject: Re: [PATCH 4/5] acpi: fix trivial warning
Date: Mon, 14 Sep 2009 08:02:29 -0700 [thread overview]
Message-ID: <1252940549.28368.255.camel@desktop> (raw)
In-Reply-To: <94a0d4530909140734q51779b76g2ddc7211ece87171@mail.gmail.com>
On Mon, 2009-09-14 at 17:34 +0300, Felipe Contreras wrote:
> On Mon, Sep 14, 2009 at 4:55 PM, Daniel Walker <dwalker@fifo99.com> wrote:
> > On Sun, 2009-09-13 at 22:38 +0300, Felipe Contreras wrote:
> >> drivers/acpi/acpica/tbfadt.c: In function ‘acpi_tb_create_local_fadt’:
> >> arch/x86/include/asm/string_32.h:74: warning: array subscript is above array bounds
> >>
> >> Signed-off-by: Felipe Contreras <felipe.contreras@gmail.com>
> >
> > Could you run this through checkpatch also, it looks like you have a few
> > style issues..
>
> I did... the style issues are already there, my patch is not
> introducing them. Do you want me to send a separate patch to fix the
> existing style issues?
Yes, If your inclined to clean up the whole file, or just the
surrounding code that would be helpful ..
Daniel
next prev parent reply other threads:[~2009-09-14 15:01 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 19:38 [PATCH 0/5] Trivial warning cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 1/5] Trivial whitespace cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 2/5] kbuild: fix warning when domainname is not available Felipe Contreras
2009-09-13 19:38 ` [PATCH 3/5] kbuild: mkcompile_h: trivial cleanups Felipe Contreras
2009-09-13 19:38 ` [PATCH 4/5] acpi: fix trivial warning Felipe Contreras
2009-09-13 19:38 ` [PATCH 5/5] acpi: fix trivial warnings caused by previous commmit Felipe Contreras
2009-09-14 13:55 ` [PATCH 4/5] acpi: fix trivial warning Daniel Walker
2009-09-14 14:34 ` Felipe Contreras
2009-09-14 15:02 ` Daniel Walker [this message]
2009-11-12 0:23 ` Felipe Contreras
2009-11-13 17:43 ` Daniel Walker
2009-11-13 20:28 ` Felipe Contreras
2009-11-13 20:37 ` Thiago Farina
2009-11-15 17:15 ` Daniel Walker
2009-11-15 17:27 ` Felipe Contreras
2009-11-15 17:32 ` Daniel Walker
2009-11-15 17:54 ` Alexey Starikovskiy
2009-11-15 17:58 ` Daniel Walker
2009-11-15 18:10 ` Alexey Starikovskiy
2009-11-15 18:09 ` Daniel Walker
2009-11-16 1:27 ` Lin Ming
2009-09-13 21:12 ` [PATCH 2/5] kbuild: fix warning when domainname is not available Mike Frysinger
2009-09-13 21:42 ` Felipe Contreras
2009-09-13 21:58 ` Mike Frysinger
2009-09-13 22:04 ` Felipe Contreras
2009-09-14 4:46 ` Sam Ravnborg
2009-09-14 8:25 ` Felipe Contreras
2009-09-14 13:43 ` Mike Frysinger
2009-09-15 8:38 ` Felipe Contreras
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1252940549.28368.255.camel@desktop \
--to=dwalker@fifo99.com \
--cc=ak@linux.intel.com \
--cc=felipe.contreras@gmail.com \
--cc=len.brown@intel.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ming.m.lin@intel.com \
--cc=robert.moore@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox