From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752706AbZIOKTz (ORCPT ); Tue, 15 Sep 2009 06:19:55 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752605AbZIOKTu (ORCPT ); Tue, 15 Sep 2009 06:19:50 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:56449 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752352AbZIOKTu (ORCPT ); Tue, 15 Sep 2009 06:19:50 -0400 Subject: Re: [PATCH 0/2] tracing: Tracing integration - dynamic ftrace for SystemTap From: Peter Zijlstra To: Atsushi Tsuji Cc: linux-kernel@vger.kernel.org, rostedt@goodmis.org, Ingo Molnar , fweisbec@gmail.com, "Frank Ch. Eigler" , paulus@samba.org, systemtap@sources.redhat.com In-Reply-To: <1253009731.5506.39.camel@laptop> References: <4AAF6724.9080201@bk.jp.nec.com> <1253009731.5506.39.camel@laptop> Content-Type: text/plain Date: Tue, 15 Sep 2009 12:19:33 +0200 Message-Id: <1253009974.5506.41.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, 2009-09-15 at 12:15 +0200, Peter Zijlstra wrote: > On Tue, 2009-09-15 at 19:06 +0900, Atsushi Tsuji wrote: > > The patches doesn't contain the performance counters integration, > > since it is still in development. I think following implementations are > > needed: > > - add new type to perf_id (like PERF_TYPE_FTRACE) > > - add event ids to struct dyn_ftrace > > - add interfaces to reference event ids by user (via debugfs?) > > - add probe function to count ftrace events (call do_perf_swcounter_event) > > That's long since been done,.. Or are you talking about the mcount thing? Simply expose the mcount hook as a regular tracepoint and perf can already use it.