From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: "Metzger, Markus T" <markus.t.metzger@intel.com>
Cc: "mingo@elte.hu" <mingo@elte.hu>,
"tglx@linutronix.de" <tglx@linutronix.de>,
"hpa@zytor.com" <hpa@zytor.com>,
"markus.t.metzger@gmail.com" <markus.t.metzger@gmail.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: RE: [patch, resend] x86, perf_counter, bts: optimize BTS overflow handling
Date: Tue, 15 Sep 2009 13:25:15 +0200 [thread overview]
Message-ID: <1253013915.5506.54.camel@laptop> (raw)
In-Reply-To: <928CFBE8E7CB0040959E56B4EA41A77EC47B0E9E@irsmsx504.ger.corp.intel.com>
On Tue, 2009-09-15 at 12:18 +0100, Metzger, Markus T wrote:
> >> Restructure perf_counter sampling into sample creation and sample
> >> output.
> >> Prepare a single reference sample for BTS sampling and update the from
> >> and to address fields when draining the BTS buffer.
> >> Drain the entire BTS buffer between a single perf_output_begin() /
> >> perf_output_end() pair.
> >
> >Generally looks very nice, one thing though, why did you take regs out
> >of perf_sample_data, now you get to pass around one extra param..
>
>
> That is to make perf_sample_data describe the sample directly.
>
> The regs are used to create the sample; they're not needed once
> the sample has been created.
True, but I'd have been lazy and not added that extra parameter all over
the place, but sure ;-)
This is now fast enough to BTS trace the kernel too?
next prev parent reply other threads:[~2009-09-15 11:25 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-15 11:00 [patch, resend] x86, perf_counter, bts: optimize BTS overflow handling Markus Metzger
2009-09-15 11:12 ` Peter Zijlstra
2009-09-15 11:18 ` Metzger, Markus T
2009-09-15 11:25 ` Peter Zijlstra [this message]
2009-09-15 11:35 ` Metzger, Markus T
2009-09-15 11:40 ` Peter Zijlstra
2009-09-15 12:19 ` Metzger, Markus T
2009-09-18 19:18 ` [tip:perfcounters/core] x86, perf_counter, bts: Optimize " tip-bot for Markus Metzger
2009-09-21 7:25 ` Metzger, Markus T
2009-09-21 7:32 ` Ingo Molnar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253013915.5506.54.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=markus.t.metzger@gmail.com \
--cc=markus.t.metzger@intel.com \
--cc=mingo@elte.hu \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox