public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: rostedt@goodmis.org
Cc: Atsushi Tsuji <a-tsuji@bk.jp.nec.com>,
	linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	fweisbec@gmail.com, "Frank Ch. Eigler" <fche@redhat.com>,
	paulus@samba.org, systemtap@sources.redhat.com
Subject: Re: [PATCH 0/2] tracing: Tracing integration - dynamic ftrace for SystemTap
Date: Tue, 15 Sep 2009 15:36:56 +0200	[thread overview]
Message-ID: <1253021816.5506.78.camel@laptop> (raw)
In-Reply-To: <1253021324.20020.88.camel@gandalf.stny.rr.com>

On Tue, 2009-09-15 at 09:28 -0400, Steven Rostedt wrote:
> On Tue, 2009-09-15 at 12:19 +0200, Peter Zijlstra wrote:
> > On Tue, 2009-09-15 at 12:15 +0200, Peter Zijlstra wrote:
> > > On Tue, 2009-09-15 at 19:06 +0900, Atsushi Tsuji wrote:
> > > > The patches doesn't contain the performance counters integration,
> > > > since it is still in development. I think following implementations are
> > > > needed:
> > > > - add new type to perf_id (like PERF_TYPE_FTRACE)
> > > > - add event ids to struct dyn_ftrace
> > > > - add interfaces to reference event ids by user (via debugfs?)
> > > > - add probe function to count ftrace events (call do_perf_swcounter_event)
> > > 
> > > That's long since been done,.. 
> > 
> > Or are you talking about the mcount thing? Simply expose the mcount hook
> > as a regular tracepoint and perf can already use it.
> > 

> I'm not sure what you mean by exposing the mcount hook as a tracepoint.
> Or you mean make it a special file in debug/tracing/events/ that lets
> you enable it as a profile trace?

Either make it a single tracepoint on which you can apply filters or
make it generate a tracepoint per mcount site, I don't really mind ;-)

If kprobes can live in the same space, then surely the function tracer
can too ;-)


  reply	other threads:[~2009-09-15 13:37 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-15 10:06 [PATCH 0/2] tracing: Tracing integration - dynamic ftrace for SystemTap Atsushi Tsuji
2009-09-15 10:15 ` Peter Zijlstra
2009-09-15 10:19   ` Peter Zijlstra
2009-09-15 13:28     ` Steven Rostedt
2009-09-15 13:36       ` Peter Zijlstra [this message]
2009-09-16  8:08         ` Atsushi Tsuji

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253021816.5506.78.camel@laptop \
    --to=peterz@infradead.org \
    --cc=a-tsuji@bk.jp.nec.com \
    --cc=fche@redhat.com \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=paulus@samba.org \
    --cc=rostedt@goodmis.org \
    --cc=systemtap@sources.redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox