public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <srostedt@redhat.com>
To: Christian Borntraeger <borntraeger@de.ibm.com>
Cc: linux-kernel@vger.kernel.org, Ingo Molnar <mingo@elte.hu>,
	Robert Richter <robert.richter@amd.com>
Subject: Re: [PATCH] Fix oprofile regression: select RING_BUFFER_ALLOW_SWAP
Date: Wed, 16 Sep 2009 16:11:30 -0400	[thread overview]
Message-ID: <1253131890.2964.168.camel@localhost.localdomain> (raw)
In-Reply-To: <200909162156.49239.borntraeger@de.ibm.com>

On Wed, 2009-09-16 at 21:56 +0200, Christian Borntraeger wrote:
> commit 85bac32c4a52c592b857f2c360cc5ec93a097d70                                                                                                                             
>     ring-buffer: only enable ring_buffer_swap_cpu when needed
> broke oprofile (at least on s390, but likely on all platforms).
> 
> this patch lets oprofile select RING_BUFER_ALLOW_SWAP to make 
> ring_buffer_swap_cpu usable for oprofile.

Thanks, I'll apply this for the 32 queue.

-- Steve

PS. Please send patches to my rostedt@goodmis.org account. I don't
always read my Red Hat email.

> 
> Signed-off-by: Christian Borntraeger <borntraeger@de.ibm.com>
> CC-ed: Steven Rostedt <srostedt@redhat.com> 
> CC-ed: Ingo Molnar <mingo@elte.hu>
> CC-ed: Robert Richter <robert.richter@amd.com>                                                                                                                      
> ---
>  arch/Kconfig |    1 +
>  1 file changed, 1 insertion(+)
> 
> Index: linux-2.6/arch/Kconfig
> ===================================================================
> --- linux-2.6.orig/arch/Kconfig
> +++ linux-2.6/arch/Kconfig
> @@ -9,6 +9,7 @@ config OPROFILE
>  	depends on TRACING_SUPPORT
>  	select TRACING
>  	select RING_BUFFER
> +	select RING_BUFFER_ALLOW_SWAP
>  	help
>  	  OProfile is a profiling system capable of profiling the
>  	  whole system, include the kernel, kernel modules, libraries,


  reply	other threads:[~2009-09-16 20:11 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-16 19:56 [PATCH] Fix oprofile regression: select RING_BUFFER_ALLOW_SWAP Christian Borntraeger
2009-09-16 20:11 ` Steven Rostedt [this message]
2009-09-16 20:54   ` Robert Richter
2009-09-17 20:16 ` [tip:tracing/core] oprofile: fix " tip-bot for Christian Borntraeger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253131890.2964.168.camel@localhost.localdomain \
    --to=srostedt@redhat.com \
    --cc=borntraeger@de.ibm.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=robert.richter@amd.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox