From: Steve Chen <schen@mvista.com>
To: Russell King - ARM Linux <linux@arm.linux.org.uk>
Cc: Sergei Shtylyov <sshtylyov@ru.mvista.com>,
Krzysztof Halasa <khc@pm.waw.pl>,
Felipe Contreras <felipe.contreras@gmail.com>,
linux-kernel@vger.kernel.org, Marek Vasut <marek.vasut@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
linux-arm-kernel@lists.infradead.org
Subject: [PATCH v2] arm: remove unused code in delay.S
Date: Thu, 17 Sep 2009 16:29:38 -0500 [thread overview]
Message-ID: <1253222978.3273.236.camel@linux-1lbu> (raw)
In-Reply-To: <20090917194119.GA12510@n2100.arm.linux.org.uk>
Document #if 0 code block in delay.S and make it selectable for compile.
Signed-off-by: Steve Chen <schen@mvista.com>
---
arch/arm/Kconfig | 14 ++++++++++++++
arch/arm/lib/delay.S | 2 +-
2 files changed, 15 insertions(+), 1 deletions(-)
diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
index aef63c8..ed8bf14 100644
--- a/arch/arm/Kconfig
+++ b/arch/arm/Kconfig
@@ -813,6 +813,20 @@ config ARM_ERRATA_460075
ACTLR register. Note that setting specific bits in the ACTLR
register
may not be available in non-secure mode.
+config OLD_CPU_DELAY
+ depends on CPU_32v3 || CPU_32v4 || CPU_32v4T
+ bool "Different delay() code for some older CPUs"
+ def_bool n
+ help
+ Enable this if observing longer than expected delays. This code
+ improves delay accuracy for some CPUs. However, it can also cause
+ delay duration to be too short for others which leads to stability
+ issues.
+
+ In other words, do not enable unless you can guarantee that the
+ processor (or ALL of the processors if building a generic kernel)
+ delays for at least the time requested after enabling.
+
endmenu
source "arch/arm/common/Kconfig"
diff --git a/arch/arm/lib/delay.S b/arch/arm/lib/delay.S
index 8d6a876..67e679b 100644
--- a/arch/arm/lib/delay.S
+++ b/arch/arm/lib/delay.S
@@ -42,7 +42,7 @@ ENTRY(__const_udelay) @ 0 <= r0 <= 0x7fffff06
@ Delay routine
ENTRY(__delay)
subs r0, r0, #1
-#if 0
+#ifdef CONFIG_OLD_CPU_DELAY
movls pc, lr
subs r0, r0, #1
movls pc, lr
next prev parent reply other threads:[~2009-09-17 21:23 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-13 21:05 [PATCH] arm: remove unused code in delay.S Felipe Contreras
2009-09-13 21:28 ` Marek Vasut
2009-09-13 23:00 ` Russell King - ARM Linux
2009-09-14 0:21 ` Jamie Lokier
2009-09-14 8:10 ` Russell King - ARM Linux
2009-09-14 12:58 ` Felipe Contreras
2009-09-14 14:00 ` Russell King - ARM Linux
2009-09-14 14:38 ` Felipe Contreras
2009-09-14 14:40 ` Russell King - ARM Linux
2009-09-14 15:14 ` Felipe Contreras
2009-09-14 15:21 ` Russell King - ARM Linux
2009-09-14 15:50 ` Felipe Contreras
2009-09-14 16:25 ` Marek Vasut
2009-09-14 16:54 ` Felipe Contreras
2009-09-14 15:36 ` Wolfram Sang
2009-09-14 16:06 ` Felipe Contreras
2009-09-14 16:24 ` Wolfram Sang
2009-09-15 10:37 ` Pavel Machek
2009-09-15 10:47 ` Felipe Contreras
2009-09-15 10:49 ` Pavel Machek
2009-09-15 11:20 ` Felipe Contreras
2009-09-15 12:29 ` Steve Chen
2009-09-15 13:41 ` Marek Vasut
2009-09-15 16:30 ` Steve Chen
2009-09-15 18:58 ` Felipe Contreras
2009-09-15 19:44 ` Steve Chen
2009-09-15 20:39 ` Marek Vasut
2009-09-15 21:04 ` Krzysztof Halasa
2009-09-15 22:26 ` Steve Chen
2009-09-15 22:47 ` Krzysztof Halasa
2009-09-16 8:26 ` Steve Chen
2009-09-16 12:30 ` Krzysztof Halasa
2009-09-16 14:49 ` Steve Chen
2009-09-16 20:21 ` Sergei Shtylyov
2009-09-16 13:47 ` Russell King - ARM Linux
2009-09-17 19:32 ` Jamie Lokier
2009-09-17 19:41 ` Russell King - ARM Linux
2009-09-17 21:29 ` Steve Chen [this message]
2009-09-17 21:37 ` [PATCH v2] " Jamie Lokier
2009-09-17 22:25 ` Steve Chen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253222978.3273.236.camel@linux-1lbu \
--to=schen@mvista.com \
--cc=felipe.contreras@gmail.com \
--cc=khc@pm.waw.pl \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=marek.vasut@gmail.com \
--cc=pavel@ucw.cz \
--cc=sshtylyov@ru.mvista.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox