Re: [PATCH tip/core/rcu 2/3] Apply results of code inspection of kernel/rcutree_plugin.h

Daniel Walker
2009-09-18T16:58:11Z

On Fri, 2009-09-18 at 09:50 -0700, Paul E. McKenney wrote:

> diff --git a/kernel/rcutree_plugin.h b/kernel/rcutree_plugin.h
> index 2b996c3..a2d586c 100644
> --- a/kernel/rcutree_plugin.h
> +++ b/kernel/rcutree_plugin.h
> @@ -117,9 +117,9 @@ static void rcu_preempt_note_context_switch(int cpu)
> * on line!
> */
> WARN_ON_ONCE((rdp->grpmask & rnp->qsmaskinit) == 0);
> - phase = !(rnp->qsmask & rdp->grpmask) ^ (rnp->gpnum & 0x1);
> + WARN_ON_ONCE(!list_empty(&t->rcu_node_entry));
> + phase = (rnp->gpnum + !(rnp->qsmask & rdp->grpmask)) & 0x1;
> list_add(&t->rcu_node_entry, &rnp->blocked_tasks[phase]);
> - smp_mb(); /* Ensure later ctxt swtch seen after above. */
> spin_unlock_irqrestore(&rnp->lock, flags);
> }

ERROR: code indent should use tabs where possible
#149: FILE: kernel/rcutree_plugin.h:120:
+^I ^IWARN_ON_ONCE(!list_empty(&t->rcu_node_entry));$

One funny indent in the line above.. If your intending for Ingo to take
this he might just fix it on apply ..

Daniel