public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@fifo99.com>
To: Nick Gasson <nick@nickg.me.uk>
Cc: linux-kernel@vger.kernel.org, dmitry.torokhov@gmail.com
Subject: Re: [PATCH] Fix fn-key release events for Samsung Q320 laptop
Date: Sat, 19 Sep 2009 06:20:58 -0700	[thread overview]
Message-ID: <1253366458.6699.51.camel@desktop> (raw)
In-Reply-To: <4AB48658.2080709@nickg.me.uk>

On Sat, 2009-09-19 at 08:20 +0100, Nick Gasson wrote:
> This adds a workaround for the missing fn-key release
> events on Samsung Q320 and similar laptops.
> 
> Tested extensively on my own laptop.
> 
> Signed-off-by: Nick Gasson <nick@nickg.me.uk>
> ---
>   drivers/input/keyboard/atkbd.c |    9 +++++++++
>   1 files changed, 9 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/input/keyboard/atkbd.c b/drivers/input/keyboard/atkbd.c
> index c9523e4..56a6ffa 100644
> --- a/drivers/input/keyboard/atkbd.c
> +++ b/drivers/input/keyboard/atkbd.c
> @@ -1630,6 +1630,15 @@ static struct dmi_system_id atkbd_dmi_quirk_table[] __initdata = {
>                  .driver_data = atkbd_samsung_forced_release_keys,
>          },
>          {
> +               .ident = "Samsung Q320/P320",
> +               .matches = {
> +                       DMI_MATCH(DMI_SYS_VENDOR, "SAMSUNG ELECTRONICS CO., LTD."),

Your patch is whitespace damaged .. All the tabs have been removed from
your code, and the context code in the patch. That usually means the
patch can't be applied .. It can happen when you X copy&paste the patch
into an email. I'd use git-format-patch and git-send-email (since your
using git anyway..)

Daniel


  reply	other threads:[~2009-09-19 13:21 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-19  7:20 [PATCH] Fix fn-key release events for Samsung Q320 laptop Nick Gasson
2009-09-19 13:20 ` Daniel Walker [this message]
2009-09-19 20:37 ` Dmitry Torokhov

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253366458.6699.51.camel@desktop \
    --to=dwalker@fifo99.com \
    --cc=dmitry.torokhov@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nick@nickg.me.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox