From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Mel Gorman <mel@csn.ul.ie>
Cc: Nick Piggin <npiggin@suse.de>,
Pekka Enberg <penberg@cs.helsinki.fi>,
Christoph Lameter <cl@linux-foundation.org>,
heiko.carstens@de.ibm.com, sachinp@in.ibm.com,
linux-kernel@vger.kernel.org, linux-mm@kvack.org,
Tejun Heo <tj@kernel.org>
Subject: Re: [RFC PATCH 0/3] Fix SLQB on memoryless configurations V2
Date: Tue, 22 Sep 2009 10:00:03 +1000 [thread overview]
Message-ID: <1253577603.7103.174.camel@pasglop> (raw)
In-Reply-To: <1253549426-917-1-git-send-email-mel@csn.ul.ie>
On Mon, 2009-09-21 at 17:10 +0100, Mel Gorman wrote:
>
> It needs signed-off from the powerpc side because it's now allocating
> more
> memory potentially (Ben?). An alternative to this patch is in V1 that
> statically declares the per-node structures but this is potentially
> sub-optimal but from a performance and memory utilisation perspective.
So if I understand correctly, we have a problem with both cpu-less and
memory-less nodes. Interesting setups :-)
I have no strong objection on the allocating of the per-cpu data for
the cpu-less nodes. However, I wonder if we should do that a bit more
nicely, maybe with some kind of "adjusted" cpu_possible_mask() (could be
something like cpu_node_valid_mask or similar) to be used by percpu.
Mostly because it would be nice to have built-in debug features in
per-cpu and in that case, it would need some way to know a valid
number from an invalid one). Either that or just keep track of the
mask of cpus that had percpu data allocated to them
Cheers,
Ben.
next prev parent reply other threads:[~2009-09-22 0:01 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-21 16:10 [RFC PATCH 0/3] Fix SLQB on memoryless configurations V2 Mel Gorman
2009-09-21 16:10 ` [PATCH 1/3] powerpc: Allocate per-cpu areas for node IDs for SLQB to use as per-node areas Mel Gorman
2009-09-21 17:17 ` Daniel Walker
2009-09-21 17:24 ` Randy Dunlap
2009-09-21 17:29 ` Daniel Walker
2009-09-21 17:42 ` Mel Gorman
2009-09-22 0:01 ` Tejun Heo
2009-09-22 9:32 ` Mel Gorman
2009-09-21 16:10 ` [PATCH 2/3] slqb: Record what node is local to a kmem_cache_cpu Mel Gorman
2009-09-21 16:10 ` [PATCH 3/3] slqb: Allow SLQB to be used on PPC Mel Gorman
2009-09-22 9:30 ` Heiko Carstens
2009-09-22 9:32 ` Mel Gorman
2009-09-21 17:46 ` [RFC PATCH 0/3] Fix SLQB on memoryless configurations V2 Mel Gorman
2009-09-21 17:54 ` Christoph Lameter
2009-09-21 18:05 ` Pekka Enberg
2009-09-21 18:07 ` Mel Gorman
2009-09-21 18:17 ` Christoph Lameter
2009-09-22 10:05 ` Mel Gorman
2009-09-22 10:21 ` Pekka Enberg
2009-09-22 10:24 ` Mel Gorman
2009-09-22 5:03 ` Sachin Sant
2009-09-22 10:07 ` Mel Gorman
2009-09-22 12:55 ` Mel Gorman
2009-09-22 13:05 ` Sachin Sant
2009-09-22 13:20 ` Mel Gorman
[not found] ` <363172900909220629j2f5174cbo9fe027354948d37@mail.gmail.com>
2009-09-22 13:38 ` Mel Gorman
2009-09-22 23:07 ` Christoph Lameter
2009-09-22 0:00 ` Benjamin Herrenschmidt [this message]
2009-09-22 0:19 ` David Rientjes
2009-09-22 6:30 ` Christoph Lameter
2009-09-22 7:59 ` David Rientjes
2009-09-22 8:11 ` Benjamin Herrenschmidt
2009-09-22 8:44 ` David Rientjes
2009-09-22 15:26 ` Mel Gorman
2009-09-22 17:31 ` David Rientjes
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253577603.7103.174.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=cl@linux-foundation.org \
--cc=heiko.carstens@de.ibm.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mel@csn.ul.ie \
--cc=npiggin@suse.de \
--cc=penberg@cs.helsinki.fi \
--cc=sachinp@in.ibm.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox