The Linux Kernel Mailing List
 help / color / mirror / Atom feed
From: Suresh Siddha <suresh.b.siddha@intel.com>
To: "tglx@linutronix.de" <tglx@linutronix.de>,
	"hpa@zytor.com" <hpa@zytor.com>, "mingo@elte.hu" <mingo@elte.hu>
Cc: jbarnes@virtuousgeek.org,
	"yinghai@kernel.org" <yinghai@kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>
Subject: [patch] x86: fix cpumask_of_pcibus() to handle nid of -1
Date: Mon, 21 Sep 2009 22:27:00 -0700	[thread overview]
Message-ID: <1253597220.2519.4.camel@sbs-t61> (raw)

On my two socket NHM-EP system, with CONFIG_DEBUG_PER_CPU_MAPS=y I see:

  cpumask_of_node(-1): no node_to_cpumask_map!
  Pid: 5635, comm: irqbalance Not tainted 2.6.31-07068-g43c1266-dirty #145
  Call Trace:
   [<ffffffff81031033>] cpumask_of_node+0x4f/0x58
   [<ffffffff811b5a8c>] local_cpus_show+0x1f/0x48
   [<ffffffff812c3c65>] dev_attr_show+0x20/0x44
   [<ffffffff810fcade>] sysfs_read_file+0xb2/0x131
   [<ffffffff810b2702>] vfs_read+0xab/0x147
   [<ffffffff810b2862>] sys_read+0x47/0x6f
   [<ffffffff8100af6b>] system_call_fastpath+0x16/0x1b

Fix x86 version of cpumask_of_pcibus() to handle node id of "-1"
(default value indicating that I/O isn't tied to any particular node).

Signed-off-by: Suresh Siddha <suresh.b.siddha@intel.com>
---

diff --git a/arch/x86/include/asm/pci.h b/arch/x86/include/asm/pci.h
index f76a162..b101e8c 100644
--- a/arch/x86/include/asm/pci.h
+++ b/arch/x86/include/asm/pci.h
@@ -143,7 +143,9 @@ static inline int __pcibus_to_node(const struct pci_bus *bus)
 static inline const struct cpumask *
 cpumask_of_pcibus(const struct pci_bus *bus)
 {
-	return cpumask_of_node(__pcibus_to_node(bus));
+	int node = __pcibus_to_node(bus);
+
+	return (node == -1) ? cpu_all_mask : cpumask_of_node(node);
 }
 #endif
 



             reply	other threads:[~2009-09-22  5:27 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22  5:27 Suresh Siddha [this message]
2009-09-22 17:06 ` [patch] x86: fix cpumask_of_pcibus() to handle nid of -1 Yinghai Lu
2009-09-22 17:16 ` David Rientjes

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253597220.2519.4.camel@sbs-t61 \
    --to=suresh.b.siddha@intel.com \
    --cc=hpa@zytor.com \
    --cc=jbarnes@virtuousgeek.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mingo@elte.hu \
    --cc=tglx@linutronix.de \
    --cc=yinghai@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox