From: Daniel Walker <dwalker@fifo99.com>
To: Linus Walleij <linus.walleij@stericsson.com>
Cc: Maciej Sosnowski <maciej.sosnowski@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] Add COH 901 318 DMA block driver
Date: Tue, 22 Sep 2009 08:33:22 -0700 [thread overview]
Message-ID: <1253633602.22454.0.camel@desktop> (raw)
In-Reply-To: <1253630313-20225-1-git-send-email-linus.walleij@stericsson.com>
On Tue, 2009-09-22 at 16:38 +0200, Linus Walleij wrote:
> + val &= ~COH901318_CX_CFG_CH_ENABLE;
> + writel(val, virtbase + COH901318_CX_CFG +
> + COH901318_CX_CFG_SPACING * channel);
> +
> + writel(val, virtbase + COH901318_CX_CFG +
> + COH901318_CX_CFG_SPACING * channel);
> + wmb();
> +
> + /* Spin-wait for it to actually go inactive */
> + while (readl(virtbase + COH901318_CX_STAT+COH901318_CX_STAT_SPACING *
> + channel) & COH901318_CX_STAT_ACTIVE) {}
You might want to add a cpu_relax() here ..
Daniel
next prev parent reply other threads:[~2009-09-22 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 14:38 [PATCH 1/2] Add COH 901 318 DMA block driver Linus Walleij
2009-09-22 15:33 ` Daniel Walker [this message]
2009-09-30 9:37 ` Linus Walleij
2009-09-30 9:52 ` Sosnowski, Maciej
2009-09-30 15:33 ` Dan Williams
2009-10-08 12:14 ` Linus Walleij
2009-09-30 15:38 ` Sosnowski, Maciej
2009-10-09 9:10 ` Linus Walleij
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253633602.22454.0.camel@desktop \
--to=dwalker@fifo99.com \
--cc=dan.j.williams@intel.com \
--cc=linus.walleij@stericsson.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.sosnowski@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox