Re: [PATCH tip/core/rcu 0/4] Josh and Ingo review feedback and bloatwatch RCU

[Peter Zijlstra <peterz@infradead.org>]

On Tue, 2009-09-22 at 15:24 -0700, Paul E. McKenney wrote:
> This patch set applies two sets of review feedback from Josh Triplett and
> checkpatch feedback from Ingo Molnar.  It also contains a forward-port
> of Bloatwatch RCU, courtesy of David Howells.

It would be much easier to review if these patches had a changelog
describing the problem they address :-)

The first one seems to do:

A)
 - aggregate 'rsp->completed == rsp->gpnum' expressions into a
   common function.

 - consistently use ACCESS_ONCE() in the above mentioned function

B)
 - use DIV_ROUND_UP()

C)
 - aggregate list_empty(&rnp->blocked_tasks[rnp->gpnum & 0x01])
expressions into a common function.


Could have been three patches, but ACK.


The second patch seems to mostly add comments, but also moves code
around and makes it static, which could have been split in two patches.

The purpose of the move code around bit could be a cleanup?

Looks to preserve the logic, but didn't go out on a limb to verify, ACK.


The third and fourth do have an adequate changelog :-)