public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@fifo99.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Avi Kivity <avi@redhat.com>, Jonathan Corbet <corbet@lwn.net>,
	Raistlin <raistlin@linux.it>,
	Peter Zijlstra <peterz@infradead.org>,
	claudio@evidence.eu.com, michael@evidence.eu.com,
	linux-kernel@vger.kernel.org, tglx@linutronix.de,
	johan.eker@ericsson.com, p.faure@akatech.ch,
	Fabio Checconi <fabio@gandalf.sssup.it>,
	Dhaval Giani <dhaval.giani@gmail.com>,
	Steven Rostedt <rostedt@goodmis.org>,
	Tommaso Cucinotta <tommaso.cucinotta@sssup.it>
Subject: Re: [RFC][PATCH] SCHED_EDF scheduling class
Date: Wed, 23 Sep 2009 07:50:59 -0700	[thread overview]
Message-ID: <1253717459.20648.39.camel@desktop> (raw)
In-Reply-To: <20090923122530.GB6390@elte.hu>

On Wed, 2009-09-23 at 14:25 +0200, Ingo Molnar wrote:
> * Avi Kivity <avi@redhat.com> wrote:
> 
> >> discouraging contributions is more something that happens when you 
> >> get the responses I got earlier in this thread..
> >
> > That's probably intentional.  Whitespace fixes have their place but 
> > not at this stage in a patch's lifecycle.
> 
> Exactly. What might make sense is to scan linux-next for new commits 
> that show serious cleanliness trouble - and send fix patches to the 
> parties involved. That's a real effort and brings the code forward.

Often times when a patch is at youngest that when you want to catch
these issues .. This EDF patch will likely get submitted more than
twice. If you catch all the minor problems first you will not be dealing
with them later when it comes time to include the code.

In this case the author is not totally aware of how to submit this
code.. I don't think it's at all inappropriate to comment on that. His
next submission will likely be much cleaner and nicer. It may even speed
up the inclusion process since he'll be more easily able to submit the
code (with practice and comments from us).

Daniel




  reply	other threads:[~2009-09-23 14:51 UTC|newest]

Thread overview: 57+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-22 10:30 [RFC][PATCH] SCHED_EDF scheduling class Raistlin
2009-09-22 11:05 ` Peter Zijlstra
2009-09-22 12:51   ` Raistlin
2009-09-22 18:36     ` Peter Zijlstra
2009-09-23 12:19       ` Raistlin
2009-09-23 12:25         ` Dhaval Giani
2009-09-27  6:55       ` Henrik Austad
2009-09-29 16:10         ` Raistlin
2009-09-29 17:34           ` Chris Friesen
2009-09-30 15:58             ` Raistlin
2009-09-30 17:35               ` Chris Friesen
2009-09-22 11:58 ` Claudio Scordino
2009-09-22 12:38   ` Peter Zijlstra
2009-09-24 16:08     ` Claudio Scordino
2009-09-22 13:24 ` Daniel Walker
2009-09-22 14:01   ` Raistlin
2009-09-22 14:02     ` Daniel Walker
2009-09-22 16:42     ` Peter Zijlstra
2009-09-22 19:11       ` Ingo Molnar
2009-09-23  0:51         ` checkpatch as a tool (was Re: [RFC][PATCH] SCHED_EDF scheduling class) Daniel Walker
2009-09-23  1:01           ` Joe Perches
2009-09-23  1:11             ` Daniel Walker
2009-09-23 19:24               ` Andy Isaacson
2009-09-24 14:58                 ` Daniel Walker
2009-09-30 12:06               ` Pavel Machek
2009-09-23 12:22             ` Ingo Molnar
2009-09-23 14:43               ` Daniel Walker
2009-09-30 12:04           ` Pavel Machek
2009-09-23  7:03         ` [RFC][PATCH] SCHED_EDF scheduling class Raistlin
2009-09-23 21:39     ` Steven Rostedt
2009-09-24  0:58       ` GeunSik Lim
2009-09-22 16:38   ` Peter Zijlstra
2009-09-22 23:39   ` Jonathan Corbet
2009-09-22 23:55     ` Daniel Walker
2009-09-23  0:06       ` Jonathan Corbet
2009-09-23  0:40         ` Daniel Walker
2009-09-23 11:46           ` Avi Kivity
2009-09-23 12:25             ` Ingo Molnar
2009-09-23 14:50               ` Daniel Walker [this message]
2009-09-23 14:58                 ` Avi Kivity
2009-09-23 15:08                   ` Daniel Walker
2009-09-23 15:12                     ` Avi Kivity
2009-09-23 15:24                       ` Daniel Walker
2009-09-30 12:05                 ` Pavel Machek
2009-09-22 20:55 ` Linus Walleij
2009-09-23 13:00   ` Raistlin
2009-09-23 13:22   ` Claudio Scordino
2009-09-23 14:08     ` Linus Walleij
2009-09-23 14:45       ` Raistlin
2009-09-23 12:33 ` Linus Walleij
2009-09-23 12:50   ` Linus Walleij
2009-09-23 13:30   ` Raistlin
2009-09-29 18:15     ` roel kluin
2009-09-30 15:59       ` Raistlin
2009-09-24  0:34 ` GeunSik Lim
2009-09-24  6:08   ` Raistlin
2009-09-24  9:11   ` Claudio Scordino

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253717459.20648.39.camel@desktop \
    --to=dwalker@fifo99.com \
    --cc=avi@redhat.com \
    --cc=claudio@evidence.eu.com \
    --cc=corbet@lwn.net \
    --cc=dhaval.giani@gmail.com \
    --cc=fabio@gandalf.sssup.it \
    --cc=johan.eker@ericsson.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=michael@evidence.eu.com \
    --cc=mingo@elte.hu \
    --cc=p.faure@akatech.ch \
    --cc=peterz@infradead.org \
    --cc=raistlin@linux.it \
    --cc=rostedt@goodmis.org \
    --cc=tglx@linutronix.de \
    --cc=tommaso.cucinotta@sssup.it \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox