From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1752260AbZIWOvG (ORCPT ); Wed, 23 Sep 2009 10:51:06 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1751531AbZIWOvF (ORCPT ); Wed, 23 Sep 2009 10:51:05 -0400 Received: from fifo99.com ([67.223.236.141]:51618 "EHLO fifo99.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1750829AbZIWOvD (ORCPT ); Wed, 23 Sep 2009 10:51:03 -0400 Subject: Re: [RFC][PATCH] SCHED_EDF scheduling class From: Daniel Walker To: Ingo Molnar Cc: Avi Kivity , Jonathan Corbet , Raistlin , Peter Zijlstra , claudio@evidence.eu.com, michael@evidence.eu.com, linux-kernel@vger.kernel.org, tglx@linutronix.de, johan.eker@ericsson.com, p.faure@akatech.ch, Fabio Checconi , Dhaval Giani , Steven Rostedt , Tommaso Cucinotta In-Reply-To: <20090923122530.GB6390@elte.hu> References: <1253615424.20345.76.camel@Palantir> <1253625878.6575.34.camel@desktop> <20090922173916.257dff1d@tpl.lwn.net> <1253663739.4317.12.camel@desktop> <20090922180611.7a47adcc@tpl.lwn.net> <1253666423.25689.30.camel@desktop> <4ABA0AA6.3010408@redhat.com> <20090923122530.GB6390@elte.hu> Content-Type: text/plain Date: Wed, 23 Sep 2009 07:50:59 -0700 Message-Id: <1253717459.20648.39.camel@desktop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, 2009-09-23 at 14:25 +0200, Ingo Molnar wrote: > * Avi Kivity wrote: > > >> discouraging contributions is more something that happens when you > >> get the responses I got earlier in this thread.. > > > > That's probably intentional. Whitespace fixes have their place but > > not at this stage in a patch's lifecycle. > > Exactly. What might make sense is to scan linux-next for new commits > that show serious cleanliness trouble - and send fix patches to the > parties involved. That's a real effort and brings the code forward. Often times when a patch is at youngest that when you want to catch these issues .. This EDF patch will likely get submitted more than twice. If you catch all the minor problems first you will not be dealing with them later when it comes time to include the code. In this case the author is not totally aware of how to submit this code.. I don't think it's at all inappropriate to comment on that. His next submission will likely be much cleaner and nicer. It may even speed up the inclusion process since he'll be more easily able to submit the code (with practice and comments from us). Daniel