From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Rafael J. Wysocki" <rjw@sisk.pl>
Cc: Jan Scholz <scholz@fias.uni-frankfurt.de>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@elte.hu>,
linux-kernel@vger.kernel.org, Adrian Bunk <bunk@kernel.org>,
pm list <linux-pm@lists.linux-foundation.org>,
Johannes Berg <johannes@sipsolutions.net>
Subject: Re: [regression, bisected] adb trackpad disappears after suspend to ram
Date: Thu, 24 Sep 2009 07:28:52 +1000 [thread overview]
Message-ID: <1253741332.7103.324.camel@pasglop> (raw)
In-Reply-To: <200909231538.51227.rjw@sisk.pl>
On Wed, 2009-09-23 at 15:38 +0200, Rafael J. Wysocki wrote:
> > This patch fixes it by using IRQF_TIMER for both the PMU and the I2C
> > interrupts. I prefer doing it this way than moving the call sites since
> > I really want those platform functions to still be called after all
> > drivers (and before sysdevs).
>
> Alternatively, you could introduce a new flag IRQF_NOSUSPEND and use that
> instead of IRQF_TIMER. That would be cleaner than using IRQF_TIMER for
> non-timer interrupts IMHO.
I totally agree. The current patch is still good for stable though.
I'll send it to Greg after I've upstreamed it, we can introduce IRQF_NOSUSPEND
in a second patch.
Ben.
next prev parent reply other threads:[~2009-09-23 21:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-25 15:44 [regression] adb trackpad disappears after suspend to ram Jan Scholz
2009-05-28 7:59 ` [regression, bisected] " Jan Scholz
2009-05-28 16:58 ` Rafael J. Wysocki
2009-05-28 22:23 ` Benjamin Herrenschmidt
2009-05-28 22:39 ` Jan Scholz
2009-05-29 18:10 ` Rafael J. Wysocki
2009-06-01 13:44 ` Jan Scholz
2009-06-01 16:36 ` Rafael J. Wysocki
2009-06-01 22:34 ` Jan Scholz
2009-06-01 22:42 ` Rafael J. Wysocki
2009-06-01 22:52 ` Benjamin Herrenschmidt
[not found] ` <200906031202.28916.rjw@sisk.pl>
2009-06-03 12:18 ` Jan Scholz
[not found] ` <200906032200.55563.rjw@sisk.pl>
[not found] ` <200906032220.19915.rjw@sisk.pl>
2009-06-03 22:17 ` [linux-pm] " Jan Scholz
2009-09-23 3:32 ` Benjamin Herrenschmidt
2009-09-23 13:38 ` Rafael J. Wysocki
2009-09-23 21:28 ` Benjamin Herrenschmidt [this message]
2009-10-07 17:10 ` Jan Scholz
2009-10-07 20:18 ` Rafael J. Wysocki
2009-09-23 23:12 ` Jan Scholz
2009-06-02 4:49 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253741332.7103.324.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=bunk@kernel.org \
--cc=johannes@sipsolutions.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@lists.linux-foundation.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=rjw@sisk.pl \
--cc=scholz@fias.uni-frankfurt.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox