Re: [GIT PULL v2] bkl tracepoints + filter regex support

Peter Zijlstra
2009-09-24T20:30:11Z

On Thu, 2009-09-24 at 22:16 +0200, Ingo Molnar wrote:

> There's one thing Peter noticed: this is not C syntax anymore. It would
> be really nice to keep filter expressions a subset of C.

Also:

> This patch provides basic support for regular expressions in filters.
>
> It supports the following types of regexp:
>
> - *match_beginning
> - *match_middle*
> - match_end*
> - !don't match
>
> Example:
> cd /debug/tracing/events/bkl/lock_kernel
> echo 'file == "*reiserfs*"' > filter
> echo 1 > enable

It says regex, but its not.

Regex would look like: "^.*reiserfs.*$", or simply "reiserfs"

What you implemented is called glob-matching.

If you want to keep this C syntax, you could consider something like:

glob_match(file, "*reiserfs*")

or something.