Re: [GIT PULL v2] bkl tracepoints + filter regex support

Frederic Weisbecker
2009-09-25T07:55:32Z

On Thu, Sep 24, 2009 at 10:22:25PM +0200, Ingo Molnar wrote:
>
> also, some build problems:
>
> include/trace/events/bkl.h: In function
> ?ftrace_profile_enable_lock_kernel?:
> include/trace/events/bkl.h:9: error: implicit declaration of function
> ?register_trace_lock_kernel?
> include/trace/events/bkl.h: In function
> ?ftrace_profile_disable_lock_kernel?:
> include/trace/events/bkl.h:9: error: implicit declaration of function
> ?unregister_trace_lock_kernel?
> include/trace/events/bkl.h: In function
> ?ftrace_profile_enable_unlock_kernel?:
> include/trace/events/bkl.h:34: error: implicit declaration of function
> ?register_trace_unlock_kernel?
> include/trace/events/bkl.h: In function
> ?ftrace_profile_disable_unlock_kernel?:
> include/trace/events/bkl.h:34: error: implicit declaration of function
> ?unregister_trace_unlock_kernel?
>
> config attached.
>
> Ingo

Ok, I see. The problem is that include/ftrace_event.h includes hardirq.h
which includes smp_lock.h, then each time we define another tracepoint, we
redefine the bkl tracepoints.

Thanks, I'll fix this.