From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Frederic Weisbecker <fweisbec@gmail.com>
Cc: Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
Tom Zanussi <tzanussi@gmail.com>,
Steven Rostedt <rostedt@goodmis.org>,
Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [GIT PULL v2] bkl tracepoints + filter regex support
Date: Thu, 24 Sep 2009 22:51:29 +0200 [thread overview]
Message-ID: <1253825489.18939.180.camel@laptop> (raw)
In-Reply-To: <20090924204357.GB8662@nowhere>
On Thu, 2009-09-24 at 22:44 +0200, Frederic Weisbecker wrote:
> I don't quite understand why.
>
> Typing file == "*reiserfs*" looks more intuitive.
>
> It's true that the filters should stay tight to the C syntax,
> but following this guideline up to the point that we are forced to
> use function expressions to do something that can be expressed
> much more easily and more intuitively (IMHO), that all sounds like
> an overkill.
>
> The use of glob is a very primary need for filters, it's
> so much a basic requirement for it that it should be native
> in its language.
The thing that my fingers know is awk syntax:
file ~ /reiserfs/
I'd very much prefer to keep == for strict equality, however the above
requires actual regex bits.
Remember, there are no second chances for the filter syntax anymore.
next prev parent reply other threads:[~2009-09-24 20:51 UTC|newest]
Thread overview: 26+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 19:49 [GIT PULL v2] bkl tracepoints + filter regex support Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 1/5 v2] tracing/bkl: Add bkl ftrace events Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 2/5 v2] tracing/filters: Cleanup useless headers Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 3/5 v2] tracing/event: Cleanup the useless dentry variable Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 4/5 v2] tracing/filters: Provide basic regex support Frederic Weisbecker
2009-09-25 8:13 ` Andrey Panin
2009-09-25 8:16 ` Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 5/5] tracing/filters: Unify the regex parsing helpers Frederic Weisbecker
2009-09-24 20:15 ` [GIT PULL v2] bkl tracepoints + filter regex support Ingo Molnar
2009-09-24 20:16 ` Ingo Molnar
2009-09-24 20:22 ` Ingo Molnar
2009-09-25 7:55 ` Frederic Weisbecker
2009-09-24 20:30 ` Peter Zijlstra
2009-09-24 20:44 ` Frederic Weisbecker
2009-09-24 20:51 ` Peter Zijlstra [this message]
2009-09-24 21:36 ` Frederic Weisbecker
2009-09-25 8:19 ` Peter Zijlstra
2009-09-25 9:12 ` Frederic Weisbecker
2009-09-25 9:40 ` Peter Zijlstra
2009-09-25 10:38 ` Frederic Weisbecker
2009-09-26 10:44 ` Steven Rostedt
2009-10-03 11:36 ` Frederic Weisbecker
2009-09-26 15:47 ` Frank Ch. Eigler
2009-10-03 11:49 ` Frederic Weisbecker
2009-09-26 10:30 ` Steven Rostedt
2009-09-24 20:33 ` Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1253825489.18939.180.camel@laptop \
--to=a.p.zijlstra@chello.nl \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=mingo@elte.hu \
--cc=rostedt@goodmis.org \
--cc=tzanussi@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox