public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Steven Rostedt <rostedt@goodmis.org>
To: Peter Zijlstra <a.p.zijlstra@chello.nl>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
	Ingo Molnar <mingo@elte.hu>, LKML <linux-kernel@vger.kernel.org>,
	Tom Zanussi <tzanussi@gmail.com>, Li Zefan <lizf@cn.fujitsu.com>
Subject: Re: [GIT PULL v2] bkl tracepoints + filter regex support
Date: Sat, 26 Sep 2009 06:30:15 -0400	[thread overview]
Message-ID: <1253961015.12145.120.camel@frodo> (raw)
In-Reply-To: <1253871601.10287.23.camel@twins>

On Fri, 2009-09-25 at 11:40 +0200, Peter Zijlstra wrote:

> Using globs in string matches most certainly is useful, no question
> about that.
> 
> But I had understood from previous communications we were going to have
> a C syntax, and there == is a straight comparison.
> 
> If however people have changed their minds (fine with me) and we're now
> going to script like things..
> 
> Anyway, a glob in == just means we have to use another operator if we
> ever want to support actual regexes, ~ would then be recommened I think,
> since that's what awk and I think perl do.

I agree that any use of '==' should be a direct match and if you want to
add a glob expression you can use something else. Like what Peter showed
(~) or even better =~ which is what perl uses.

/me runs

;-)

-- Steve

> 
> Personally I wouldn't mind things like:
> 
>  glob_match(string, pattern)
>  regex_match(string, pattern)
> 
> But everybody involved in this filter stuff needs to agree what
> direction you want to take the language in.



  parent reply	other threads:[~2009-09-26 10:31 UTC|newest]

Thread overview: 26+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-24 19:49 [GIT PULL v2] bkl tracepoints + filter regex support Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 1/5 v2] tracing/bkl: Add bkl ftrace events Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 2/5 v2] tracing/filters: Cleanup useless headers Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 3/5 v2] tracing/event: Cleanup the useless dentry variable Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 4/5 v2] tracing/filters: Provide basic regex support Frederic Weisbecker
2009-09-25  8:13   ` Andrey Panin
2009-09-25  8:16     ` Frederic Weisbecker
2009-09-24 19:49 ` [PATCH 5/5] tracing/filters: Unify the regex parsing helpers Frederic Weisbecker
2009-09-24 20:15 ` [GIT PULL v2] bkl tracepoints + filter regex support Ingo Molnar
2009-09-24 20:16   ` Ingo Molnar
2009-09-24 20:22     ` Ingo Molnar
2009-09-25  7:55       ` Frederic Weisbecker
2009-09-24 20:30     ` Peter Zijlstra
2009-09-24 20:44       ` Frederic Weisbecker
2009-09-24 20:51         ` Peter Zijlstra
2009-09-24 21:36           ` Frederic Weisbecker
2009-09-25  8:19             ` Peter Zijlstra
2009-09-25  9:12               ` Frederic Weisbecker
2009-09-25  9:40                 ` Peter Zijlstra
2009-09-25 10:38                   ` Frederic Weisbecker
2009-09-26 10:44                     ` Steven Rostedt
2009-10-03 11:36                       ` Frederic Weisbecker
2009-09-26 15:47                     ` Frank Ch. Eigler
2009-10-03 11:49                       ` Frederic Weisbecker
2009-09-26 10:30                   ` Steven Rostedt [this message]
2009-09-24 20:33     ` Frederic Weisbecker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1253961015.12145.120.camel@frodo \
    --to=rostedt@goodmis.org \
    --cc=a.p.zijlstra@chello.nl \
    --cc=fweisbec@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lizf@cn.fujitsu.com \
    --cc=mingo@elte.hu \
    --cc=tzanussi@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox