From: Tony Vroon <tony@linx.net>
To: Tejun Heo <tj@kernel.org>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
Rusty Russell <rusty@rustcorp.com.au>,
Christoph Lameter <cl@linux-foundation.org>,
Ingo Molnar <mingo@elte.hu>, "H. Peter Anvin" <hpa@zytor.com>
Subject: Re: [PATCH] percpu: fix unit_map[] verification in pcpu_setup_first_chunk()
Date: Mon, 28 Sep 2009 23:07:42 +0100 [thread overview]
Message-ID: <1254175662.2783.1.camel@localhost> (raw)
In-Reply-To: <4AC0E201.2020006@kernel.org>
[-- Attachment #1: Type: text/plain, Size: 592 bytes --]
On Tue, 2009-09-29 at 01:19 +0900, Tejun Heo wrote:
> pcpu_setup_first_chunk() incorrectly used NR_CPUS as the impossible
> unit number while unit number can equal and go over NR_CPUS with
> sparse unit map. This triggers BUG_ON() spuriously on machines which
> have non-power-of-two number of cpus. Use UINT_MAX instead.
>
> Signed-off-by: Tejun Heo <tj@kernel.org>
> Reported-by: Tony Vroon <tony@linx.net>
Tested-by: Tony Vroon <tony@linx.net>
> Erghh... stupid mistake. This should fix it. Can you please verify?
Confirmed fixed. Thank you Tejun.
Regards,
Tony V.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 198 bytes --]
next prev parent reply other threads:[~2009-09-28 22:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-24 0:53 [PATCH] percpu: make pcpu_setup_first_chunk() failures more verbose Tejun Heo
2009-09-24 12:49 ` [PATCH] percpu: make allocation " Tejun Heo
2009-09-27 12:49 ` 2.6.31-09194-g0d9df25 Early boot exception Tony Vroon
2009-09-28 16:19 ` [PATCH] percpu: fix unit_map[] verification in pcpu_setup_first_chunk() Tejun Heo
2009-09-28 16:25 ` Christoph Lameter
2009-09-28 16:35 ` Tejun Heo
2009-09-28 16:38 ` Tejun Heo
2009-09-28 16:40 ` Christoph Lameter
2009-09-28 16:53 ` Tejun Heo
2009-09-28 22:07 ` Tony Vroon [this message]
2009-09-29 0:15 ` Tejun Heo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254175662.2783.1.camel@localhost \
--to=tony@linx.net \
--cc=cl@linux-foundation.org \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=rusty@rustcorp.com.au \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).