From: Steven Rostedt <rostedt@goodmis.org>
To: Paul Mackerras <paulus@samba.org>
Cc: Frederic Weisbecker <fweisbec@gmail.com>,
Ingo Molnar <mingo@elte.hu>,
Peter Zijlstra <peterz@infradead.org>,
linux-kernel@vger.kernel.org
Subject: Re: Possible bug in ftrace_profile_enable_event
Date: Thu, 01 Oct 2009 02:20:35 -0400 [thread overview]
Message-ID: <1254378035.2194.37.camel@frodo> (raw)
In-Reply-To: <19140.13582.223629.56214@cargo.ozlabs.ibm.com>
On Thu, 2009-10-01 at 14:50 +1000, Paul Mackerras wrote:
> So we only allocate trace_profile_buf and trace_profile_buf_nmi if
> total_profile_count was zero on entry, but if we get an error returned
> from event->profile_enable(), we free them both unconditionally,
> regardless of the value of total_profile_count. That seems wrong. Is
> there a subtle reason why that is the right thing to do?
>
> (Also, is kfree the appropriate counterpart to alloc_percpu?)
Hi Paul,
I think you have a valid point. Frederic and I are here in Dresden (last
day). I'll make sure he sees this.
Thanks,
-- Steve
next prev parent reply other threads:[~2009-10-01 6:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-01 4:50 Possible bug in ftrace_profile_enable_event Paul Mackerras
2009-10-01 6:20 ` Steven Rostedt [this message]
2009-10-02 12:13 ` Frédéric Weisbecker
2009-10-03 13:47 ` [GIT PULL] tracing: Perf tracing fixes Frederic Weisbecker
2009-10-03 13:57 ` Frederic Weisbecker
2009-10-05 17:54 ` Frederic Weisbecker
2009-10-06 12:30 ` Ingo Molnar
2009-10-03 13:47 ` [PATCH 1/2] tracing: Check total refcount before releasing bufs in profile_enable failure Frederic Weisbecker
2009-10-07 3:08 ` Paul Mackerras
2009-10-08 21:43 ` Frederic Weisbecker
2009-10-08 21:53 ` Paul Mackerras
2009-10-03 13:47 ` [PATCH 2/2] tracing: Use free_percpu instead of kfree Frederic Weisbecker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254378035.2194.37.camel@frodo \
--to=rostedt@goodmis.org \
--cc=fweisbec@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=paulus@samba.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).