public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Johannes Berg <johannes@sipsolutions.net>
To: Pavel Machek <pavel@ucw.cz>
Cc: linux-kernel@vger.kernel.org, yi.zhu@intel.com,
	reinette.chatre@intel.com, linux-wireless@vger.kernel.org
Subject: Re: 2.6.32-rc0-git: oops in wireless, iwl3945 related?
Date: Thu, 01 Oct 2009 23:27:49 +0200	[thread overview]
Message-ID: <1254432469.3959.46.camel@johannes.local> (raw)
In-Reply-To: <1254431783.3959.45.camel@johannes.local>

On Thu, 2009-10-01 at 23:16 +0200, Johannes Berg wrote:

> > wlan0: Selected IBSS BSSID 02:18:41:de:3f:02 based on configured SSID
> > wlan0: Trigger new scan to find an IBSS to join
> > wlan0: Trigger new scan to find an IBSS to join
> > wlan0: Creating new IBSS network, BSSID f2:d3:80:82:ed:6a
> > wlan0: Creating new IBSS network, BSSID 52:17:bf:45:d6:9d
> > skb_over_panic: text:c07b4113 len:130 put:36 head:e4c3edf0
> 
> This entire log is very odd ... can you reproduce this easily? printk
> timestamps would be useful.

Kinda looks like a race condition, but it's rather odd. I think there's
a race condition, so I'm going to submit this patch regardless after
some testing, but if you want please try the patch below.

johannes

---
 net/mac80211/ibss.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

--- wireless-testing.orig/net/mac80211/ibss.c	2009-10-01 23:21:11.000000000 +0200
+++ wireless-testing/net/mac80211/ibss.c	2009-10-01 23:22:24.000000000 +0200
@@ -831,7 +831,7 @@ void ieee80211_ibss_notify_scan_complete
 		if (!sdata->u.ibss.ssid_len)
 			continue;
 		sdata->u.ibss.last_scan_completed = jiffies;
-		ieee80211_sta_find_ibss(sdata);
+		mod_timer(&ifibss->timer, 0);
 	}
 	mutex_unlock(&local->iflist_mtx);
 }



  reply	other threads:[~2009-10-01 21:27 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-09-29 17:12 2.6.32-rc0-git: oops in wireless, iwl3945 related? Pavel Machek
2009-09-29 18:14 ` reinette chatre
2009-10-01 21:16 ` Johannes Berg
2009-10-01 21:27   ` Johannes Berg [this message]
2009-10-17 18:33     ` Pavel Machek
2009-10-17 22:00       ` Johannes Berg
2009-10-01 22:24   ` Pavel Machek
2009-10-01 22:28     ` Johannes Berg

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1254432469.3959.46.camel@johannes.local \
    --to=johannes@sipsolutions.net \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-wireless@vger.kernel.org \
    --cc=pavel@ucw.cz \
    --cc=reinette.chatre@intel.com \
    --cc=yi.zhu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox