linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
* [PATCH] drivers/video/backlight: memset region size error
@ 2009-10-03 14:36 Jan Ceuleers
  2009-10-03 17:00 ` Richard Purdie
  0 siblings, 1 reply; 2+ messages in thread
From: Jan Ceuleers @ 2009-10-03 14:36 UTC (permalink / raw)
  To: Richard Purdie; +Cc: linux-kernel

>From 61755f56b829f59a40f9d30799651f80a3554104 Mon Sep 17 00:00:00 2001
From: Jan Ceuleers <jan.ceuleers@computer.org>
Date: Sat, 3 Oct 2009 16:00:36 +0200
Subject: [PATCH] drivers/video/backlight: memset region size error

The size of the region to be memset() should be the size
of the target rather than the size of the pointer to it.

Compile-tested only.

Signed-off-by: Jan Ceuleers <jan.ceuleers@computer.org>

---
 drivers/video/backlight/lcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/video/backlight/lcd.c b/drivers/video/backlight/lcd.c
index b644947..a482dd7 100644
--- a/drivers/video/backlight/lcd.c
+++ b/drivers/video/backlight/lcd.c
@@ -56,7 +56,7 @@ static int fb_notifier_callback(struct notifier_block *self,
 
 static int lcd_register_fb(struct lcd_device *ld)
 {
-	memset(&ld->fb_notif, 0, sizeof(&ld->fb_notif));
+	memset(&ld->fb_notif, 0, sizeof(ld->fb_notif));
 	ld->fb_notif.notifier_call = fb_notifier_callback;
 	return fb_register_client(&ld->fb_notif);
 }
-- 
1.5.4.3

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] drivers/video/backlight: memset region size error
  2009-10-03 14:36 [PATCH] drivers/video/backlight: memset region size error Jan Ceuleers
@ 2009-10-03 17:00 ` Richard Purdie
  0 siblings, 0 replies; 2+ messages in thread
From: Richard Purdie @ 2009-10-03 17:00 UTC (permalink / raw)
  To: Jan Ceuleers; +Cc: linux-kernel

On Sat, 2009-10-03 at 16:36 +0200, Jan Ceuleers wrote:
> From 61755f56b829f59a40f9d30799651f80a3554104 Mon Sep 17 00:00:00 2001
> From: Jan Ceuleers <jan.ceuleers@computer.org>
> Date: Sat, 3 Oct 2009 16:00:36 +0200
> Subject: [PATCH] drivers/video/backlight: memset region size error
> 
> The size of the region to be memset() should be the size
> of the target rather than the size of the pointer to it.
> 
> Compile-tested only.
> 
> Signed-off-by: Jan Ceuleers <jan.ceuleers@computer.org>

The same patch was posted yesterday by Jean Delvare and I've queued that
but thanks!

Cheers,

Richard
-- 
Richard Purdie
Intel Open Source Technology Centre


^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2009-10-03 18:19 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-03 14:36 [PATCH] drivers/video/backlight: memset region size error Jan Ceuleers
2009-10-03 17:00 ` Richard Purdie

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).