From: Daniel Walker <dwalker@fifo99.com>
To: Krzysztof Halasa <khc@pm.waw.pl>
Cc: Andy Whitcroft <apw@canonical.com>,
Li Zefan <lizf@cn.fujitsu.com>,
Andrew Morton <akpm@linux-foundation.org>,
linux-kernel@vger.kernel.org,
Steven Rostedt <rostedt@goodmis.org>
Subject: Re: [PATCH 3/5] checkpatch: add a blacklist
Date: Tue, 06 Oct 2009 20:52:14 -0700 [thread overview]
Message-ID: <1254887534.18167.253.camel@desktop> (raw)
In-Reply-To: <m33a5ww8kn.fsf@intrepid.localdomain>
On Tue, 2009-10-06 at 22:50 +0200, Krzysztof Halasa wrote:
> Daniel Walker <dwalker@fifo99.com> writes:
>
> > In terms of the list getting long or not, your basically in control of
> > it since you maintain checkpatch .. If you leave it without some sort of
> > blacklist, then you end up with whole sections of code where the
> > developers don't use checkpatch at all (or very little)..
>
> Why? I routinely ignore specific warnings from checkpatch while paying
> attention to other ones. That's precisely what one should expect if the
> code in question technically violates the common style (or whatever is
> it). I don't think we need exceptions in the checkpatch as they would
> make it less useful and less reliable.
This thread is specifically about checkpatch errors .. checkpatch
warnings can be ignored, but errors you can't usually ignore.. If your
ignoring errors then either checkpatch is producing bogus output that
needs to be corrected, or it's something you really should fix..
Daniel
next prev parent reply other threads:[~2009-10-07 3:53 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-09-22 2:14 [PATCH 1/5] checkpatch: fix false errors due to macro concatenation Daniel Walker
2009-09-22 2:14 ` [PATCH 2/5] checkpatch: fix hang in relative indent checking Daniel Walker
2009-09-22 2:14 ` [PATCH 3/5] checkpatch: add a blacklist Daniel Walker
2009-09-22 2:14 ` [PATCH 4/5] checkpatch: fix __attribute__ matching Daniel Walker
2009-09-22 2:14 ` [PATCH 5/5] checkpatch: fix false EXPORT_SYMBOL warning Daniel Walker
2009-09-30 17:46 ` Andy Whitcroft
2009-10-01 14:28 ` Daniel Walker
2009-10-02 7:39 ` Andy Whitcroft
2009-09-30 17:46 ` [PATCH 4/5] checkpatch: fix __attribute__ matching Andy Whitcroft
2009-10-01 14:26 ` Daniel Walker
2009-10-02 7:43 ` Andy Whitcroft
2009-09-22 6:29 ` [PATCH 3/5] checkpatch: add a blacklist Li Zefan
2009-09-30 15:27 ` Andy Whitcroft
2009-10-01 14:18 ` Daniel Walker
2009-10-06 19:51 ` Steven Rostedt
2009-10-06 20:50 ` Krzysztof Halasa
2009-10-07 3:52 ` Daniel Walker [this message]
2009-10-07 10:17 ` Krzysztof Halasa
2009-10-07 14:26 ` Daniel Walker
2009-10-07 14:44 ` Krzysztof Halasa
2009-10-07 14:57 ` Daniel Walker
2009-10-07 15:11 ` Alan Cox
2009-10-07 15:41 ` Daniel Walker
2009-10-07 15:52 ` Alan Cox
2009-10-07 16:11 ` Daniel Walker
2009-10-07 15:08 ` Steven Rostedt
2009-10-07 15:38 ` Daniel Walker
2009-10-07 21:30 ` Krzysztof Halasa
2009-10-07 21:58 ` Daniel Walker
2009-09-30 15:24 ` [PATCH 2/5] checkpatch: fix hang in relative indent checking Andy Whitcroft
2009-09-30 17:46 ` [PATCH 1/5] checkpatch: fix false errors due to macro concatenation Andy Whitcroft
2009-10-01 14:20 ` Daniel Walker
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1254887534.18167.253.camel@desktop \
--to=dwalker@fifo99.com \
--cc=akpm@linux-foundation.org \
--cc=apw@canonical.com \
--cc=khc@pm.waw.pl \
--cc=linux-kernel@vger.kernel.org \
--cc=lizf@cn.fujitsu.com \
--cc=rostedt@goodmis.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).