From: Daniel Walker <dwalker@fifo99.com>
To: Ingo Molnar <mingo@elte.hu>
Cc: Linus Torvalds <torvalds@linux-foundation.org>,
Greg Kroah-Hartman <gregkh@suse.de>, Theodore Tso <tytso@mit.edu>,
James Bottomley <James.Bottomley@suse.de>,
Andrew Morton <akpm@linux-foundation.org>,
linux-scsi <linux-scsi@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Jing Huang <huangj@brocade.com>
Subject: Re: [GIT PULL] SCSI fixes for 2.6.32-rc3
Date: Fri, 09 Oct 2009 06:10:10 -0700 [thread overview]
Message-ID: <1255093810.18167.398.camel@desktop> (raw)
In-Reply-To: <20091009091538.GA4154@elte.hu>
On Fri, 2009-10-09 at 11:15 +0200, Ingo Molnar wrote:
>
> I dont know what's the current mainline inclusion quality threshold for
> non-staging Linux drivers - it might be ok. Also, the driver commit has
> been rebased a few days ago which makes it hard to see its stability
> track record.
>
> Ingo
>
> --------------->
> ERROR: return is not a function, parentheses are not required
> #191: FILE: fcbuild.c:191:
> + return (FC_PARSE_BUSY);
The author submitted a basic style clean up here,
http://patchwork.kernel.org/patch/50161/
It was a series that did the whole driver.. I'm not sure why those
patches aren't included, but at least there was an attempt at cleaning
the driver up..
Daniel
next prev parent reply other threads:[~2009-10-09 13:11 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-06 15:46 [GIT PULL] SCSI fixes for 2.6.32-rc3 James Bottomley
2009-10-06 15:58 ` Linus Torvalds
2009-10-06 20:54 ` James Bottomley
2009-10-06 20:56 ` Randy Dunlap
2009-10-08 14:33 ` James Bottomley
2009-10-08 14:39 ` Linus Torvalds
2009-10-08 14:54 ` Linus Torvalds
2009-10-08 19:48 ` James Bottomley
2009-10-08 19:55 ` Linus Torvalds
2009-10-08 20:00 ` Linus Torvalds
2009-10-08 21:07 ` Theodore Tso
2009-10-08 21:13 ` Linus Torvalds
2009-10-09 9:15 ` Ingo Molnar
2009-10-09 13:10 ` Daniel Walker [this message]
2009-10-09 14:08 ` James Bottomley
2009-10-09 19:25 ` Greg KH
2009-10-12 13:06 ` Ingo Molnar
2009-10-12 14:19 ` James Bottomley
2009-10-12 14:54 ` Ingo Molnar
2009-10-12 15:09 ` Moving drivers into staging (was Re: [GIT PULL] SCSI fixes for 2.6.32-rc3) Greg KH
2009-10-12 15:42 ` Ingo Molnar
2009-10-12 23:24 ` Greg KH
2009-10-13 18:08 ` Luis R. Rodriguez
2009-10-14 4:45 ` Greg KH
2009-10-14 5:19 ` Joe Perches
2009-10-14 6:33 ` Ingo Molnar
2009-10-14 14:13 ` James Smart
2009-10-14 17:52 ` Stefan Richter
2009-10-14 18:36 ` Ingo Molnar
2009-10-14 19:00 ` Stefan Richter
2009-10-15 6:03 ` Ingo Molnar
2009-10-14 19:11 ` Greg KH
2009-10-12 15:43 ` James Bottomley
2009-10-12 23:26 ` Greg KH
2009-10-12 15:25 ` [GIT PULL] SCSI fixes for 2.6.32-rc3 James Bottomley
2009-10-12 17:24 ` Linus Torvalds
2009-10-13 14:29 ` James Bottomley
2009-10-12 14:25 ` Greg KH
2009-10-08 20:04 ` James Bottomley
2009-10-08 20:25 ` Linus Torvalds
2009-10-10 14:37 ` James Bottomley
2009-10-08 14:56 ` James Bottomley
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255093810.18167.398.camel@desktop \
--to=dwalker@fifo99.com \
--cc=James.Bottomley@suse.de \
--cc=akpm@linux-foundation.org \
--cc=gregkh@suse.de \
--cc=huangj@brocade.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-scsi@vger.kernel.org \
--cc=mingo@elte.hu \
--cc=torvalds@linux-foundation.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).