From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Ben Efros <ben@pc-doctor.com>
Cc: Alan Stern <stern@rowland.harvard.edu>,
fangxiaozhi <huananhu@huawei.com>, Greg KH <greg@kroah.com>,
Kernel development list <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
Hugh Blemings <hugh@blemings.org>,
Josua Dietze <digidietze@draisberghof.de>
Subject: Re: USB serial regression 2.6.31.1 -> 2.6.31.2
Date: Sun, 11 Oct 2009 16:24:41 +1100 [thread overview]
Message-ID: <1255238681.2192.30.camel@pasglop> (raw)
In-Reply-To: <32355889.563271255220486481.JavaMail.root@mail.pc-doctor.com>
On Sat, 2009-10-10 at 17:21 -0700, Ben Efros wrote:
>
> Ben Herrenschmidt's patch[1] to retry without SANE_SENSE might be
> combined be able to be used to detect this 'INSANE_SENSE' scenario,
> but not in its current form.
>
> Devices lying about the "additional sense length" doesn't seem all
> that common, so it might be better to just flag the device as insane
> and not worry about reworking Ben Herrenschmidt's patch.
I don't like flagging devices ... though we already somewhat do it for
the mode switch so it would be possible to stick the flag there.
Another option is to set the insane flag from a retry path similar
to what I posted so that it doesn't ping pong.
In any case, a decision should be made soon as current -stable is broken
and these devices are very common.
Cheers,
Ben.
next prev parent reply other threads:[~2009-10-11 5:26 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <11818577.563251255220394815.JavaMail.root@mail.pc-doctor.com>
2009-10-11 0:21 ` USB serial regression 2.6.31.1 -> 2.6.31.2 Ben Efros
2009-10-11 5:24 ` Benjamin Herrenschmidt [this message]
2009-10-10 0:25 Benjamin Herrenschmidt
2009-10-10 7:38 ` Josua Dietze
2009-10-10 7:41 ` Benjamin Herrenschmidt
2009-10-10 9:55 ` Oliver Neukum
2009-10-10 15:05 ` Greg KH
2009-10-10 17:05 ` Alan Stern
2009-10-10 17:43 ` Ondrej Zary
2009-10-10 20:41 ` Alan Stern
2009-10-10 21:20 ` Benjamin Herrenschmidt
2009-10-10 22:17 ` Benjamin Herrenschmidt
2009-10-11 14:45 ` Alan Stern
2009-10-10 21:18 ` Benjamin Herrenschmidt
2009-10-10 21:56 ` Benjamin Herrenschmidt
2009-10-10 22:52 ` Alan Stern
2009-10-10 23:26 ` Benjamin Herrenschmidt
2009-10-10 23:47 ` Benjamin Herrenschmidt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255238681.2192.30.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=ben@pc-doctor.com \
--cc=digidietze@draisberghof.de \
--cc=greg@kroah.com \
--cc=huananhu@huawei.com \
--cc=hugh@blemings.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox