From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1759430AbZJKK7C (ORCPT ); Sun, 11 Oct 2009 06:59:02 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1756869AbZJKK7B (ORCPT ); Sun, 11 Oct 2009 06:59:01 -0400 Received: from bombadil.infradead.org ([18.85.46.34]:47983 "EHLO bombadil.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1753571AbZJKK7A (ORCPT ); Sun, 11 Oct 2009 06:59:00 -0400 Subject: Re: [PATCH 01/45] writeback: reduce calls to global_page_state in balance_dirty_pages() From: Peter Zijlstra To: Wu Fengguang Cc: Jan Kara , Andrew Morton , Theodore Tso , Christoph Hellwig , Dave Chinner , Chris Mason , "Li, Shaohua" , Myklebust Trond , "jens.axboe@oracle.com" , Nick Piggin , "linux-fsdevel@vger.kernel.org" , Richard Kennedy , LKML In-Reply-To: <20091011105012.GB10409@localhost> References: <20091007073818.318088777@intel.com> <20091007074901.251116016@intel.com> <20091009151230.GF7654@duck.suse.cz> <1255101512.8802.65.camel@laptop> <20091009154759.GJ7654@duck.suse.cz> <20091011022813.GA21315@localhost> <1255247080.11081.3.camel@twins> <20091011105012.GB10409@localhost> Content-Type: text/plain Date: Sun, 11 Oct 2009 12:58:01 +0200 Message-Id: <1255258681.8967.170.camel@laptop> Mime-Version: 1.0 X-Mailer: Evolution 2.26.1 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, 2009-10-11 at 18:50 +0800, Wu Fengguang wrote: > > Sorry for the confusion, but I mean, filesystems have to limit > nr_writeback (directly or indirectly via the block io queue), > otherwise it either hit nr_dirty to 0 (with the loop), or let > nr_writeback grow out of control (without the loop). OK, it seems we are indeed in agreement. Just making sure ;-)