From: Ben Hutchings <ben@decadent.org.uk>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: linux-kernel@vger.kernel.org, Eric Sesterhenn <snakebyte@gmx.de>,
Roman Zippel <zippel@linux-m68k.org>,
550010@bugs.debian.org
Subject: Re: [PATCH] hfsplus: Refuse to mount volumes larger than 2TB
Date: Sun, 11 Oct 2009 18:01:30 +0100 [thread overview]
Message-ID: <1255280490.25061.280.camel@localhost> (raw)
In-Reply-To: <20091011005153.cc723dca.akpm@linux-foundation.org>
[-- Attachment #1: Type: text/plain, Size: 815 bytes --]
On Sun, 2009-10-11 at 00:51 -0700, Andrew Morton wrote:
[...]
> > --- a/fs/hfsplus/wrapper.c
> > +++ b/fs/hfsplus/wrapper.c
> > @@ -99,6 +99,10 @@
> >
> > if (hfsplus_get_last_session(sb, &part_start, &part_size))
> > return -EINVAL;
> > + if (part_start + part_size > 0x100000000) {
> > + pr_err("hfs: volumes larger than 2TB are not supported yet\n");
> > + return -EINVAL;
> > + }
>
> part_start and part_size are sector_t. This code will do weird overflow
> things when sector_t is 32-bit.
Sorry, I forgot CONFIG_LBD is still optional.
> Also 32-bit compilers will get upset at the excessively large hex constant.
[...]
Good point.
Ben.
--
Ben Hutchings
DNRC Motto: I can please only one person per day.
Today is not your day. Tomorrow isn't looking good either.
[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 828 bytes --]
prev parent reply other threads:[~2009-10-11 17:02 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-07 2:51 hfsplus corrupts filesystems >2TB Ben Hutchings
2009-10-11 2:11 ` [PATCH] hfsplus: Refuse to mount volumes larger than 2TB Ben Hutchings
2009-10-11 7:51 ` Andrew Morton
2009-10-11 17:01 ` Ben Hutchings [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255280490.25061.280.camel@localhost \
--to=ben@decadent.org.uk \
--cc=550010@bugs.debian.org \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=snakebyte@gmx.de \
--cc=zippel@linux-m68k.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox