From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754049AbZJLHpJ (ORCPT ); Mon, 12 Oct 2009 03:45:09 -0400 Received: (majordomo@vger.kernel.org) by vger.kernel.org id S1752129AbZJLHpJ (ORCPT ); Mon, 12 Oct 2009 03:45:09 -0400 Received: from mga01.intel.com ([192.55.52.88]:16538 "EHLO mga01.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751014AbZJLHpI (ORCPT ); Mon, 12 Oct 2009 03:45:08 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="4.44,544,1249282800"; d="scan'208";a="735431351" Subject: Re: [PATCH 5/5] PCI: fix memory leak in aer_inject From: Huang Ying To: Andrew Patterson Cc: "prarit@redhat.com" , "andi@firstfloor.org" , "linux-kernel@vger.kernel.org" , "jbarnes@virtuousgeek.org" , "pci-linux@vger.kernel.org" In-Reply-To: <20091012070314.27029.35077.stgit@bob.kio> References: <20091012070248.27029.78378.stgit@bob.kio> <20091012070314.27029.35077.stgit@bob.kio> Content-Type: text/plain Date: Mon, 12 Oct 2009 15:44:30 +0800 Message-Id: <1255333470.6047.141.camel@yhuang-dev.sh.intel.com> Mime-Version: 1.0 X-Mailer: Evolution 2.26.3 Content-Transfer-Encoding: 7bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Mon, 2009-10-12 at 15:03 +0800, Andrew Patterson wrote: > PCI: fix memory leak in aer_inject > > Fixed probable typo in aer_inject cleanup code resulting in a memory > leak. > > Signed-off-by: Andrew Patterson > --- > > diff --git a/drivers/pci/pcie/aer/aer_inject.c b/drivers/pci/pcie/aer/aer_inject.c > index da2ad6e..2246bf7 100644 > --- a/drivers/pci/pcie/aer/aer_inject.c > +++ b/drivers/pci/pcie/aer/aer_inject.c > @@ -474,7 +474,7 @@ static void __exit aer_inject_exit(void) > } > > spin_lock_irqsave(&inject_lock, flags); > - list_for_each_entry_safe(err, err_next, &pci_bus_ops_list, list) { > + list_for_each_entry_safe(err, err_next, &einjected, list) { > list_del(&err->list); > kfree(err); > } Thanks for the patch. Acked-by: Huang Ying Best Regards, Huang Ying