From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751448AbcGNMsa (ORCPT ); Thu, 14 Jul 2016 08:48:30 -0400 Received: from mout.kundenserver.de ([212.227.126.134]:60816 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751051AbcGNMs1 (ORCPT ); Thu, 14 Jul 2016 08:48:27 -0400 From: Arnd Bergmann To: linux-arm-kernel@lists.infradead.org Cc: Rob Herring , Krzysztof Kozlowski , linux-samsung-soc@vger.kernel.org, Kefeng Wang , linux-kernel@vger.kernel.org, Kukjin Kim Subject: Re: [PATCH] ARM: s3c64xx: avoid warning about 'struct device_node' Date: Thu, 14 Jul 2016 14:47:31 +0200 Message-ID: <12553444.SKUaCZubIO@wuerfel> User-Agent: KMail/5.1.3 (Linux/4.4.0-28-generic; KDE/5.18.0; x86_64; ; ) In-Reply-To: <4080443.gtvsF1A0TV@wuerfel> References: <20160627110303.3391769-1-arnd@arndb.de> <1807726.lxvlsY5ymW@wuerfel> <4080443.gtvsF1A0TV@wuerfel> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:G+6JchkT+Y5NDxVjWLgKyIQSrPU6321Kohsg3ZbSxifmSH58cdV DK+oTCNjW19WWQv3aqzRXVN748MxOEFqHiwrLOJRThRhpUMjWfBWEXh83kXtXhF41XgM062 mda1BNHYu/vSyEEH8L9AdYqSf0Obhpm0mTPOxDrLLnI/QzxIuOcFIrPPrpVLiJjRZfrXa/J iwd+kFupb8ZAhxT6bOzew== X-UI-Out-Filterresults: notjunk:1;V01:K0:LS3TXfsVs/U=:Hh7MuBmpAtIV41Q33MXeGN uoBSUrY/kUdIK7qFevqy8hFZ4eBWA+Wv3X7AotNxdbpEtNGO1TrN9Qj6+wHW1wKvGQ0auQ4Q6 bNpfR1GHQYL4ky9ywIRdAAyREgmI7eH0oybm30kCiE1Mf5ulGjTubdxjdLrwpPqhe3hb06JMi BCbMM5JZdsiq9I0L5dQ8p0eDrWjLOJVuAGTXDA/iipVl2h/LFUmp7HV+XwM475P/sNdcIFxCQ qvYW/6Dvo7a9MrjDwnWIEyUnSqbW8eoCLcamYgbpXq8BGIVq98Ua3aB9iFIslmGCK3mXJYNo7 zWKBqT0Sf58Mt7J5iIVjQr2BtZDwLFKt+MJ3voXWxRr0qfz2+B4QqbMzReHapDBVqaO0AoD7l t2q4VxSdPgg1rZ5ITr80fIZVuoaPyz43+LeiolyGImXjULVuwdM1CgEcPKHI/sZ0nCgd4I4FM WquIgFNHN4jXFyUdGgyjQG1JPCbMD0VXdsRjZnb0CDRFDaxEZoeZtC8BhjxXz6nh1rbC5AJrc iq7us3MgykJbKPvFDiluRV1Z8k+NYzohVchv+H8s87nic9Kj0uELzgAw4DRZKWfDyXGLsW5x7 2lGcmdCBwMx0L0i6yTS7JY/CaCoR5MFoj94lqo55j0Wey2yTkEasxV4VsZhUIl2eFEkoowftF qqfh4zu8qqtdg6GW/hZMIXsdqCTIrFK1UDf8a4LUfQbu/opkdQ6EJGYitXZLdVjD9y5IbE6Ih mqH4hbwYoUP2KObv Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Monday, July 11, 2016 1:40:45 PM CEST Arnd Bergmann wrote: > On Monday, July 11, 2016 1:15:11 PM CEST Arnd Bergmann wrote: > > On Monday, June 27, 2016 1:33:51 PM CEST Krzysztof Kozlowski wrote: > > > On 06/27/2016 01:02 PM, Arnd Bergmann wrote: > > > > The change to simplify of_platform_populate() had an unintended > > > > side-effect of introducing a build warning on s3c64xx: > > > > > > > > In file included from arch/arm/mach-s3c64xx/mach-s3c64xx-dt.c:18:0: > > > > arch/arm/mach-s3c64xx/common.h:27:30: error: 'struct device_node' declared inside parameter list will not be visible outside of this definition or declaration [-Werror] > > > > > > > > This adds a forward-declaration for the structure name in the > > > > header to avoid the warning. > > > > > > > > Signed-off-by: Arnd Bergmann > > > > Fixes: 850bea2335e4 ("arm: Remove unnecessary of_platform_populate with default match table") > > > > --- > > > > Rob, can you apply this on top of the devicetree git so we don't > > > > have to coordinate the merges? > > > > > > Acked-by: Krzysztof Kozlowski > > > > Hi Rob, > > > > I still get the warning in every linux-next build, do you plan to pick > > up the fix for the commit you merged, or should I try to work around it > > in arm-soc and leave this as a bisection problem? > > > > Now with Rob back on Cc. I've applied it to arm-soc/next/cleanup now, so we can avoid the warning in linux-next and in 4.8, though it is still present in the devicetree git. Arnd