From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Stern <stern@rowland.harvard.edu>
Cc: Ben Efros <ben@pc-doctor.com>,
Josua Dietze <digidietze@draisberghof.de>,
fangxiaozhi <huananhu@huawei.com>, Greg KH <greg@kroah.com>,
Kernel development list <linux-kernel@vger.kernel.org>,
USB list <linux-usb@vger.kernel.org>,
Hugh Blemings <hugh@blemings.org>
Subject: Re: USB serial regression 2.6.31.1 -> 2.6.31.2 [PATCH]
Date: Tue, 13 Oct 2009 08:19:46 +1100 [thread overview]
Message-ID: <1255382386.2192.125.camel@pasglop> (raw)
In-Reply-To: <Pine.LNX.4.44L0.0910121052550.11420-100000@netrider.rowland.org>
On Mon, 2009-10-12 at 10:58 -0400, Alan Stern wrote:
> Except that this is wrong. We can retry if temp_result ==
> USB_STOR_TRANSPORT_FAILURE, but we should not retry if temp_result ==
> USB_STOR_TRANSPORT_ERROR.
>
> Alan Stern
>
> P.S.: In case you don't already know... TRANSPORT_FAILURE means we
> were able to communicate with the device, and it told us that it
> couldn't carry out the command. TRANSPORT_ERROR means we weren't able
> to communicate with the device.
Ah good, I was wondering about precisely that (discriminating the errors
more intelligently). No point retrying if the device was yanked or went
totally dead.
Cheers,
Ben.
next prev parent reply other threads:[~2009-10-12 21:21 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <26767470.564301255277612694.JavaMail.root@mail.pc-doctor.com>
2009-10-11 16:16 ` USB serial regression 2.6.31.1 -> 2.6.31.2 [PATCH] Ben Efros
2009-10-12 5:44 ` Benjamin Herrenschmidt
2009-10-12 14:58 ` Alan Stern
2009-10-12 15:12 ` Matthew Dharm
2009-10-12 15:18 ` Ben Efros
2009-10-12 21:19 ` Benjamin Herrenschmidt [this message]
2009-10-13 4:53 ` Benjamin Herrenschmidt
2009-10-13 14:03 ` Alan Stern
2009-10-13 23:30 ` Benjamin Herrenschmidt
2009-10-14 2:29 ` Greg KH
[not found] <19395543.564391255279074897.JavaMail.root@mail.pc-doctor.com>
2009-10-11 16:38 ` Ben Efros
2009-10-11 20:51 ` Benjamin Herrenschmidt
2009-10-12 1:54 ` Alan Stern
2009-10-12 3:28 ` Benjamin Herrenschmidt
2009-10-12 14:27 ` Alan Stern
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255382386.2192.125.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=ben@pc-doctor.com \
--cc=digidietze@draisberghof.de \
--cc=greg@kroah.com \
--cc=huananhu@huawei.com \
--cc=hugh@blemings.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-usb@vger.kernel.org \
--cc=stern@rowland.harvard.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox