public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Peter Zijlstra <peterz@infradead.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Michael Kerrisk <mtk.manpages@googlemail.com>,
	torvalds@linux-foundation.org, eranian@googlemail.com,
	hch@lst.de, oleg@redhat.com, roland@redhat.com,
	viro@zeniv.linux.org.uk, akpm@linux-foundation.org,
	Ulrich Drepper <drepper@gmail.com>,
	LKML <linux-kernel@vger.kernel.org>
Subject: [PATCH] fcntl: rename F_OWNER_GID to F_OWNER_PGRP
Date: Tue, 13 Oct 2009 10:13:23 +0200	[thread overview]
Message-ID: <1255421603.8392.87.camel@twins> (raw)

I noticed this patch never quite made it to LKML..

---
Subject: fcntl: rename F_OWNER_GID to F_OWNER_PGRP
From: Peter Zijlstra <a.p.zijlstra@chello.nl>
Date: Mon, 05 Oct 2009 14:44:47 +0200

On Sat, 2009-10-03 at 14:09 +0200, Michael Kerrisk wrote:
> Please, could you change F_OWNER_GID to F_OWNER_PGRP.
>
> This is for consistency with various ioctl() operations that include
> the suffix "PGRP" in their names, and also for consistency with
> PRIO_PGRP, used with setpriority() and getpriority(). Also, using PGRP
> instead of GID avoids confusion with the common abbreviation of "group
> ID".

I'm fine with anything that makes it more consistent, and if PGRP is
what is the predominant abbreviation then I see no need to further
confuse matters by adding a third one.

Signed-off-by: Peter Zijlstra <a.p.zijlstra@chello.nl>
Acked-by: Michael Kerrisk <mtk.manpages@gmail.com>
---
 fs/fcntl.c                  |    4 ++--
 include/asm-generic/fcntl.h |    2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

Index: linux-2.6/fs/fcntl.c
===================================================================
--- linux-2.6.orig/fs/fcntl.c
+++ linux-2.6/fs/fcntl.c
@@ -284,7 +284,7 @@ static int f_setown_ex(struct file *filp
 		type = PIDTYPE_PID;
 		break;
 
-	case F_OWNER_GID:
+	case F_OWNER_PGRP:
 		type = PIDTYPE_PGID;
 		break;
 
@@ -321,7 +321,7 @@ static int f_getown_ex(struct file *filp
 		break;
 
 	case PIDTYPE_PGID:
-		owner.type = F_OWNER_GID;
+		owner.type = F_OWNER_PGRP;
 		break;
 
 	default:
Index: linux-2.6/include/asm-generic/fcntl.h
===================================================================
--- linux-2.6.orig/include/asm-generic/fcntl.h
+++ linux-2.6/include/asm-generic/fcntl.h
@@ -80,7 +80,7 @@
 
 #define F_OWNER_TID	0
 #define F_OWNER_PID	1
-#define F_OWNER_GID	2
+#define F_OWNER_PGRP	2
 
 struct f_owner_ex {
 	int	type;


                 reply	other threads:[~2009-10-13  8:14 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1255421603.8392.87.camel@twins \
    --to=peterz@infradead.org \
    --cc=akpm@linux-foundation.org \
    --cc=drepper@gmail.com \
    --cc=eranian@googlemail.com \
    --cc=hch@lst.de \
    --cc=linux-kernel@vger.kernel.org \
    --cc=mtk.manpages@googlemail.com \
    --cc=oleg@redhat.com \
    --cc=roland@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox