From: Peter Zijlstra <a.p.zijlstra@chello.nl>
To: Richard Kennedy <richard@rsk.demon.co.uk>
Cc: Wu Fengguang <fengguang.wu@intel.com>,
lkml <linux-kernel@vger.kernel.org>,
Martin Bligh <mbligh@google.com>
Subject: Re: bdi_threshold slow to reach steady state
Date: Wed, 14 Oct 2009 16:04:32 +0200 [thread overview]
Message-ID: <1255529072.8392.436.camel@twins> (raw)
In-Reply-To: <1255528520.2360.94.camel@castor>
On Wed, 2009-10-14 at 14:55 +0100, Richard Kennedy wrote:
>
> commit 11735a2336ba08cf21aebf79a706c86aca5e44b2
> Author: Richard Kennedy <richard@rsk.demon.co.uk>
> Date: Wed Oct 14 14:46:21 2009 +0100
>
> mm: speed up per bdi dirty threshold calculations
I think the subject is confusing, we don't actually compute things
faster in the less cycles sense.
We reduce the dampening for the control system, yielding faster
convergence.
> Signed-off-by: Richard Kennedy <richard@rsk.demon.co.uk>
>
> diff --git a/mm/page-writeback.c b/mm/page-writeback.c
> index a3b1409..018024e 100644
> --- a/mm/page-writeback.c
> +++ b/mm/page-writeback.c
> @@ -144,7 +144,7 @@ static int calc_period_shift(void)
> else
> dirty_total = (vm_dirty_ratio *
> determine_dirtyable_memory()) /
> 100;
> - return 2 + ilog2(dirty_total - 1);
> + return ilog2(dirty_total - 1) - 2;
> }
next prev parent reply other threads:[~2009-10-14 14:05 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-14 11:09 bdi_threshold slow to reach steady state Richard Kennedy
2009-10-14 11:37 ` Peter Zijlstra
2009-10-14 13:55 ` Richard Kennedy
2009-10-14 14:04 ` Peter Zijlstra [this message]
2009-10-15 9:22 ` Richard Kennedy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255529072.8392.436.camel@twins \
--to=a.p.zijlstra@chello.nl \
--cc=fengguang.wu@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mbligh@google.com \
--cc=richard@rsk.demon.co.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox