From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: Alan Cox <alan@lxorguk.ukuu.org.uk>
Cc: Andrew Morton <akpm@linux-foundation.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
Russell King <linux@arm.linux.org.uk>,
Michael Reed <mreed10@us.ibm.com>
Subject: Re: [PATCH] 8250_pci: Add IBM Saturn serial card
Date: Thu, 15 Oct 2009 08:01:36 +1100 [thread overview]
Message-ID: <1255554096.2347.53.camel@pasglop> (raw)
In-Reply-To: <20091014124825.21b4386c@lxorguk.ukuu.org.uk>
On Wed, 2009-10-14 at 12:48 +0100, Alan Cox wrote:
> On Wed, 14 Oct 2009 10:40:53 +1100
> Benjamin Herrenschmidt <benh@kernel.crashing.org> wrote:
>
> > The IBM Saturn serial card has only one port. Without that fixup,
> > the kernel thinks it has two, which confuses userland setup and
> > admin tools as well.
> >
> > Signed-off-by: Benjamin Herrenschmidt <benh@kernel.crashing.org>
>
> Looks good to me but can you drop a space between the last DEVICE_ID and
> the VENDOR_ID bit in the header to follow the style ?
Ok. It was between the last IBM device ID and the IBM subvendor, I
wasn't sure if that warranted a blank line :-)
I'll send a new patch from work.
Cheers,
Ben.
prev parent reply other threads:[~2009-10-14 21:02 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-13 23:40 [PATCH] 8250_pci: Add IBM Saturn serial card Benjamin Herrenschmidt
2009-10-14 2:41 ` Andrew Morton
2009-10-14 3:26 ` Benjamin Herrenschmidt
2009-10-14 11:48 ` Alan Cox
2009-10-14 21:01 ` Benjamin Herrenschmidt [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1255554096.2347.53.camel@pasglop \
--to=benh@kernel.crashing.org \
--cc=akpm@linux-foundation.org \
--cc=alan@lxorguk.ukuu.org.uk \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@arm.linux.org.uk \
--cc=mreed10@us.ibm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox