public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
* [PATCH 1/1] Added an additional Sony laptop to acpi_osi_dmi_table
@ 2009-10-15  0:59 Tim Hoppen
  2009-10-15  1:45 ` Zhang, Rui
  2009-10-15  1:48 ` Daniel Walker
  0 siblings, 2 replies; 3+ messages in thread
From: Tim Hoppen @ 2009-10-15  0:59 UTC (permalink / raw)
  Cc: lenb, rui.zhang, jgarzik, tj, linux-acpi, linux-kernel,
	Tim Hoppen


Signed-off-by: Tim Hoppen <timhoppen@gmail.com>
---
 drivers/acpi/blacklist.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index e56b2a7..01cca5f 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -211,6 +211,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "Sony VGN-SR290J"),
 		},
 	},
+	{
+        .callback = dmi_disable_osi_vista,
+        .ident = "Sony VGN-FW351J",
+        .matches = {
+                     DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+                     DMI_MATCH(DMI_PRODUCT_NAME, "VGN-FW351J"),
+                },
+        },
 
 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
-- 
1.6.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* RE: [PATCH 1/1] Added an additional Sony laptop to acpi_osi_dmi_table
  2009-10-15  0:59 [PATCH 1/1] Added an additional Sony laptop to acpi_osi_dmi_table Tim Hoppen
@ 2009-10-15  1:45 ` Zhang, Rui
  2009-10-15  1:48 ` Daniel Walker
  1 sibling, 0 replies; 3+ messages in thread
From: Zhang, Rui @ 2009-10-15  1:45 UTC (permalink / raw)
  To: Tim Hoppen
  Cc: lenb@kernel.org, jgarzik@redhat.com, tj@kernel.org,
	linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org

Is there any bug report for this issue?
If yes, can you add the link in the change log please?

Thanks,
Rui

-----Original Message-----
From: Tim Hoppen [mailto:timhoppen@gmail.com] 
Sent: Thursday, October 15, 2009 9:00 AM
Cc: lenb@kernel.org; Zhang, Rui; jgarzik@redhat.com; tj@kernel.org; linux-acpi@vger.kernel.org; linux-kernel@vger.kernel.org; Tim Hoppen
Subject: [PATCH 1/1] Added an additional Sony laptop to acpi_osi_dmi_table


Signed-off-by: Tim Hoppen <timhoppen@gmail.com>
---
 drivers/acpi/blacklist.c |    8 ++++++++
 1 files changed, 8 insertions(+), 0 deletions(-)

diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
index e56b2a7..01cca5f 100644
--- a/drivers/acpi/blacklist.c
+++ b/drivers/acpi/blacklist.c
@@ -211,6 +211,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
 		     DMI_MATCH(DMI_PRODUCT_NAME, "Sony VGN-SR290J"),
 		},
 	},
+	{
+        .callback = dmi_disable_osi_vista,
+        .ident = "Sony VGN-FW351J",
+        .matches = {
+                     DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
+                     DMI_MATCH(DMI_PRODUCT_NAME, "VGN-FW351J"),
+                },
+        },
 
 	/*
 	 * BIOS invocation of _OSI(Linux) is almost always a BIOS bug.
-- 
1.6.5


^ permalink raw reply related	[flat|nested] 3+ messages in thread

* Re: [PATCH 1/1] Added an additional Sony laptop to acpi_osi_dmi_table
  2009-10-15  0:59 [PATCH 1/1] Added an additional Sony laptop to acpi_osi_dmi_table Tim Hoppen
  2009-10-15  1:45 ` Zhang, Rui
@ 2009-10-15  1:48 ` Daniel Walker
  1 sibling, 0 replies; 3+ messages in thread
From: Daniel Walker @ 2009-10-15  1:48 UTC (permalink / raw)
  To: Tim Hoppen; +Cc: lenb, rui.zhang, jgarzik, tj, linux-acpi, linux-kernel

On Wed, 2009-10-14 at 17:59 -0700, Tim Hoppen wrote:
> Signed-off-by: Tim Hoppen <timhoppen@gmail.com>
> ---
>  drivers/acpi/blacklist.c |    8 ++++++++
>  1 files changed, 8 insertions(+), 0 deletions(-)
> 
> diff --git a/drivers/acpi/blacklist.c b/drivers/acpi/blacklist.c
> index e56b2a7..01cca5f 100644
> --- a/drivers/acpi/blacklist.c
> +++ b/drivers/acpi/blacklist.c
> @@ -211,6 +211,14 @@ static struct dmi_system_id acpi_osi_dmi_table[] __initdata = {
>  		     DMI_MATCH(DMI_PRODUCT_NAME, "Sony VGN-SR290J"),
>  		},
>  	},
> +	{
> +        .callback = dmi_disable_osi_vista,
> +        .ident = "Sony VGN-FW351J",
> +        .matches = {
> +                     DMI_MATCH(DMI_SYS_VENDOR, "Sony Corporation"),
> +                     DMI_MATCH(DMI_PRODUCT_NAME, "VGN-FW351J"),
> +                },
> +        },

It looks like your not indenting correctly. The above lines should be
tabbed instead of just spaced over .. You may have done copy and paste
on this block from the code around this. Copy and paste usually doesn't
properly copy the tabs .. Could you resubmit this with the tabbing added
back in?

Daniel 


^ permalink raw reply	[flat|nested] 3+ messages in thread

end of thread, other threads:[~2009-10-15  1:50 UTC | newest]

Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-10-15  0:59 [PATCH 1/1] Added an additional Sony laptop to acpi_osi_dmi_table Tim Hoppen
2009-10-15  1:45 ` Zhang, Rui
2009-10-15  1:48 ` Daniel Walker

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox