Re: [PATCH 6/7] checkpatch: fix false EXPORT_SYMBOL warning

Andy Whitcroft
2009-10-16T23:26:12Z

On Fri, Oct 16, 2009 at 11:58:21AM -0700, Daniel Walker wrote:
> On Fri, 2009-10-16 at 19:39 +0100, Andy Whitcroft wrote:
>
> > - WARN("EXPORT_SYMBOL(foo); should immediately follow its function/variable\n" . $herecurr);
> > +#print "FOO A<$lines[$realline_next - 1]> stat<$stat> name<$name>\n";
> > + $suppress_export{$realline_next} = 2;
> > + } else {
> > + $suppress_export{$realline_next} = 1;
> > }
> > }
> > + if (!defined $suppress_export{$linenr} &&
> > + $prevline =~ /^.\s*$/ &&
> > + ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||
> > + $line =~ /EXPORT_UNUSED_SYMBOL.*\((.*)\)/)) {
>
> ERROR: code indent should use tabs where possible
> #148: FILE: scripts/checkpatch.pl:1734:
> + ($line =~ /EXPORT_SYMBOL.*\((.*)\)/ ||$
>
> This one line is spaced over instead of tabbed.. I guess checkpatch can
> even check itself, which is nice .. I'm not sure this matters since this
> it's perl tho..
>
> Do you apply any kind of coding style to checkpatch itself ?

Yeah normally I checkpatch it, and ignore the width issues as the long
regexps are not always sensibly wrappable. I rushed this lot out as I
am travelling tommorrow. Sigh. Never rush out a set of patches.

-apw