public inbox for linux-kernel@vger.kernel.org
 help / color / mirror / Atom feed
From: Daniel Walker <dwalker@fifo99.com>
To: Erwan Velu <erwanaliasr1@gmail.com>
Cc: linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH] dmi_check_system can generate Warnings when no DMI table is present
Date: Fri, 23 Oct 2009 03:08:57 -0700	[thread overview]
Message-ID: <1256292537.10493.48.camel@desktop> (raw)
In-Reply-To: <4AE178AF.3010804@gmail.com>

On Fri, 2009-10-23 at 11:34 +0200, Erwan Velu wrote:
> diff --git a/drivers/firmware/dmi_scan.c b/drivers/firmware/dmi_scan.c
> index 938100f..ea8b433 100644
> --- a/drivers/firmware/dmi_scan.c
> +++ b/drivers/firmware/dmi_scan.c
> @@ -457,6 +457,9 @@ int dmi_check_system(const struct dmi_system_id
> *list)
>      int count = 0;
>      const struct dmi_system_id *d;
>  
> +    if (!dmi_available)
> +        return 0;
> +
>      for (d = list; d->ident; d++)
>          if (dmi_matches(d)) {
>              count++;

It looks like all the tabs have been removed from the code. Did you copy
and paste the patch content into this email? Often times that will
remove the tabs.

Daniel


  reply	other threads:[~2009-10-23 10:09 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-10-23  9:34 [PATCH] dmi_check_system can generate Warnings when no DMI table is present Erwan Velu
2009-10-23 10:08 ` Daniel Walker [this message]
2009-10-23 10:34   ` Erwan Velu
2009-10-23 10:42     ` Daniel Walker
2009-10-23 10:46       ` Erwan Velu
2009-10-23 11:00         ` Ingo Molnar
2009-10-23 11:03 ` Ingo Molnar
2009-10-23 11:49   ` Erwan Velu
2009-10-23 12:47     ` Daniel Walker
2009-10-23 15:03       ` Erwan Velu
2009-10-23 15:09         ` Daniel Walker
2009-10-23 15:30           ` Ingo Molnar
2009-10-23 17:00             ` Jeremy Fitzhardinge
2009-10-23 17:04               ` Ingo Molnar
2009-10-23 17:31                 ` Jeremy Fitzhardinge
2009-10-23 16:57 ` Jeremy Fitzhardinge

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1256292537.10493.48.camel@desktop \
    --to=dwalker@fifo99.com \
    --cc=erwanaliasr1@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox