From: Stefani Seibold <stefani@seibold.net>
To: Andi Kleen <andi@firstfloor.org>
Cc: linux-kernel <linux-kernel@vger.kernel.org>,
Andrew Morton <akpm@linux-foundation.org>,
Arnd Bergmann <arnd@arndb.de>,
Amerigo Wang <xiyou.wangcong@gmail.com>,
Joe Perches <joe@perches.com>
Subject: Re: [PATCH 0/7] kfifo: new API v0.6
Date: Sun, 25 Oct 2009 09:12:24 +0100 [thread overview]
Message-ID: <1256458344.4026.3.camel@wall-e> (raw)
In-Reply-To: <20091025014831.GC32470@one.firstfloor.org>
Am Sonntag, den 25.10.2009, 02:48 +0100 schrieb Andi Kleen:
> On Sat, Oct 24, 2009 at 03:33:14PM +0200, Stefani Seibold wrote:
> > This is a new generic kernel FIFO implementation.
> >
> > The current kernel fifo API is not very widely used, because it has to many
> > constrains. Only 17 files in the current 2.6.31-rc5 used it. FIFO's are
> > like list's a very basic thing and a kfifo API which handles the most use
> > case would save a lot of development time and memory resources.
> >
> > I think this are the reasons why kfifo is not in use:
> >
> > - The API is to simple, important functions are missing
> > - A fifo can be only allocated dynamically
> > - There is a need of a spinlock despite you need it or not
> > - There is no support for data records inside a fifo
>
> I have some plans to use this kfifo code in upcoming code (mostly
> as a very simple lower overhead NMI safe per CPU fifo). I would appreciate
> if it could be merged ASAP
>
> I didn't review this iteration, but earlier ones.
>
There was no modification in the code since the last version. I added
only the function kfifo_avail_rec which has no site effect to the rest
of the code.
> Acked-by: Andi Kleen <ak@linux.intel.com>
>
> -Andi
Stefani
next prev parent reply other threads:[~2009-10-25 8:12 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-24 13:33 [PATCH 0/7] kfifo: new API v0.6 Stefani Seibold
2009-10-24 13:35 ` [PATCH 1/7] " Stefani Seibold
2009-10-24 13:36 ` [PATCH 2/7] " Stefani Seibold
2009-10-24 13:38 ` [PATCH 3/7] " Stefani Seibold
2009-10-24 13:40 ` [PATCH 4/7] " Stefani Seibold
2009-10-24 13:42 ` [PATCH 5/7] " Stefani Seibold
2009-10-24 13:44 ` [PATCH 6/7] " Stefani Seibold
2009-10-24 13:45 ` [PATCH 7/7] " Stefani Seibold
2009-10-25 1:48 ` [PATCH 0/7] " Andi Kleen
2009-10-25 8:12 ` Stefani Seibold [this message]
2009-10-30 22:24 ` Greg KH
2009-10-31 7:50 ` Stefani Seibold
2009-10-31 19:10 ` Greg KH
2009-11-01 9:50 ` Stefani Seibold
-- strict thread matches above, loose matches on Subject: below --
2009-10-28 1:49 Andy Walls
2009-10-28 3:20 ` Andi Kleen
2009-10-28 5:36 ` Mauro Carvalho Chehab
2009-11-16 11:50 Stefani Seibold
2009-11-18 21:33 ` Andrew Morton
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256458344.4026.3.camel@wall-e \
--to=stefani@seibold.net \
--cc=akpm@linux-foundation.org \
--cc=andi@firstfloor.org \
--cc=arnd@arndb.de \
--cc=joe@perches.com \
--cc=linux-kernel@vger.kernel.org \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox