From: Peter Zijlstra <peterz@infradead.org>
To: Arjan van de Ven <arjan@infradead.org>
Cc: mingo@elte.hu, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/3] sched: Add aggressive load balancing for certain situations
Date: Sun, 25 Oct 2009 12:48:15 +0100 [thread overview]
Message-ID: <1256471295.7356.13.camel@laptop> (raw)
In-Reply-To: <1256457686.7356.4.camel@laptop>
On Sun, 2009-10-25 at 09:01 +0100, Peter Zijlstra wrote:
>
> > diff --git a/kernel/sched_fair.c b/kernel/sched_fair.c
> > index 4e777b4..fe9b95b 100644
> > --- a/kernel/sched_fair.c
> > +++ b/kernel/sched_fair.c
> > @@ -1246,7 +1246,7 @@ static int wake_affine(struct sched_domain *sd, struct task_struct *p, int sync)
> > */
> > static struct sched_group *
> > find_idlest_group(struct sched_domain *sd, struct task_struct *p,
> > - int this_cpu, int load_idx)
> > + int this_cpu, int load_idx, int agressive)
> > {
>
> can't we fold that into load_idx? like -1 or something?
A better alternative might be passing imbalance along instead.
next prev parent reply other threads:[~2009-10-25 11:48 UTC|newest]
Thread overview: 35+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-10-24 19:58 [PATCH 1/3] sched: Enable wake balancing for the SMT/HT domain Arjan van de Ven
2009-10-24 20:04 ` [PATCH 2/3] sched: Add aggressive load balancing for certain situations Arjan van de Ven
2009-10-24 20:07 ` [PATCH 3/3] sched: Disable affine wakeups by default Arjan van de Ven
2009-10-25 6:55 ` Mike Galbraith
2009-10-25 16:51 ` Arjan van de Ven
2009-10-25 17:38 ` Mike Galbraith
2009-10-25 19:33 ` Arjan van de Ven
2009-10-25 22:04 ` Mike Galbraith
2009-10-26 1:53 ` Peter Zijlstra
2009-10-26 4:38 ` Mike Galbraith
2009-10-26 4:52 ` Arjan van de Ven
2009-10-26 5:08 ` Mike Galbraith
2009-10-26 5:36 ` Arjan van de Ven
2009-10-26 5:47 ` Mike Galbraith
2009-10-26 5:57 ` Mike Galbraith
2009-10-26 7:01 ` Ingo Molnar
2009-10-26 7:05 ` Arjan van de Ven
2009-10-26 11:33 ` Suresh Siddha
2009-11-10 21:59 ` Peter Zijlstra
2009-11-11 6:01 ` Arjan van de Ven
2009-10-27 14:35 ` Mike Galbraith
2009-10-28 7:25 ` Mike Galbraith
2009-10-28 18:36 ` Mike Galbraith
2009-11-04 19:33 ` [tip:sched/core] sched: Check for an idle shared cache in select_task_rq_fair() tip-bot for Mike Galbraith
2009-11-04 20:37 ` Mike Galbraith
2009-11-04 21:41 ` Mike Galbraith
2009-11-05 9:30 ` Ingo Molnar
2009-11-05 9:57 ` Mike Galbraith
2009-11-05 10:00 ` Mike Galbraith
2009-11-06 7:09 ` [tip:sched/core] sched: Fix affinity logic " tip-bot for Mike Galbraith
2009-10-26 5:21 ` [PATCH 3/3] sched: Disable affine wakeups by default Mike Galbraith
2009-10-25 8:01 ` Peter Zijlstra
2009-10-25 8:01 ` [PATCH 2/3] sched: Add aggressive load balancing for certain situations Peter Zijlstra
2009-10-25 11:48 ` Peter Zijlstra [this message]
2009-10-25 8:03 ` [PATCH 1/3] sched: Enable wake balancing for the SMT/HT domain Peter Zijlstra
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1256471295.7356.13.camel@laptop \
--to=peterz@infradead.org \
--cc=arjan@infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@elte.hu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox